summaryrefslogtreecommitdiff
path: root/gitlab/v4/objects/clusters.py
diff options
context:
space:
mode:
authorJohn L. Villalovos <john@sodarock.com>2021-03-07 11:31:23 -0800
committerNejc Habjan <hab.nejc@gmail.com>2021-04-17 17:09:41 +0200
commitaee1f496c1f414c1e30909767d53ae624fe875e7 (patch)
tree04a7fe9d8f77cffeae733bb8dd3447911995f3a1 /gitlab/v4/objects/clusters.py
parent8603248f73d8c751023fbfd2a394c5b7d939af7f (diff)
downloadgitlab-aee1f496c1f414c1e30909767d53ae624fe875e7.tar.gz
chore: have _create_attrs & _update_attrs be a namedtuple
Convert _create_attrs and _update_attrs to use a NamedTuple (RequiredOptional) to help with code readability. Update all code to use the NamedTuple.
Diffstat (limited to 'gitlab/v4/objects/clusters.py')
-rw-r--r--gitlab/v4/objects/clusters.py24
1 files changed, 11 insertions, 13 deletions
diff --git a/gitlab/v4/objects/clusters.py b/gitlab/v4/objects/clusters.py
index 2a7064e..50b3fa3 100644
--- a/gitlab/v4/objects/clusters.py
+++ b/gitlab/v4/objects/clusters.py
@@ -1,5 +1,5 @@
from gitlab import exceptions as exc
-from gitlab.base import RESTManager, RESTObject
+from gitlab.base import RequiredOptional, RESTManager, RESTObject
from gitlab.mixins import CRUDMixin, CreateMixin, ObjectDeleteMixin, SaveMixin
@@ -19,13 +19,12 @@ class GroupClusterManager(CRUDMixin, RESTManager):
_path = "/groups/%(group_id)s/clusters"
_obj_cls = GroupCluster
_from_parent_attrs = {"group_id": "id"}
- _create_attrs = (
- ("name", "platform_kubernetes_attributes"),
- ("domain", "enabled", "managed", "environment_scope"),
+ _create_attrs = RequiredOptional(
+ required=("name", "platform_kubernetes_attributes"),
+ optional=("domain", "enabled", "managed", "environment_scope"),
)
- _update_attrs = (
- tuple(),
- (
+ _update_attrs = RequiredOptional(
+ optional=(
"name",
"domain",
"management_project_id",
@@ -64,13 +63,12 @@ class ProjectClusterManager(CRUDMixin, RESTManager):
_path = "/projects/%(project_id)s/clusters"
_obj_cls = ProjectCluster
_from_parent_attrs = {"project_id": "id"}
- _create_attrs = (
- ("name", "platform_kubernetes_attributes"),
- ("domain", "enabled", "managed", "environment_scope"),
+ _create_attrs = RequiredOptional(
+ required=("name", "platform_kubernetes_attributes"),
+ optional=("domain", "enabled", "managed", "environment_scope"),
)
- _update_attrs = (
- tuple(),
- (
+ _update_attrs = RequiredOptional(
+ optional=(
"name",
"domain",
"management_project_id",