diff options
author | John L. Villalovos <john@sodarock.com> | 2021-05-31 10:47:03 -0700 |
---|---|---|
committer | John L. Villalovos <john@sodarock.com> | 2021-06-10 07:39:58 -0700 |
commit | c7bcc25a361f9df440f9c972672e5eec3b057625 (patch) | |
tree | de9bc431060437fe259115c920c67389a0cccb5f /tests/unit/test_base.py | |
parent | 161bb0bf1684374ed01c4e3bc8ebc2f5afe7546b (diff) | |
download | gitlab-c7bcc25a361f9df440f9c972672e5eec3b057625.tar.gz |
fix: catch invalid type used to initialize RESTObject
Sometimes we have errors where we don't get a dictionary passed to
RESTObject.__init__() method. This breaks things but in confusing
ways.
Check in the __init__() method and raise an exception if it occurs.
Diffstat (limited to 'tests/unit/test_base.py')
-rw-r--r-- | tests/unit/test_base.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tests/unit/test_base.py b/tests/unit/test_base.py index b3a58fc..8872dbd 100644 --- a/tests/unit/test_base.py +++ b/tests/unit/test_base.py @@ -19,6 +19,7 @@ import pickle import pytest +import gitlab from gitlab import base @@ -85,6 +86,10 @@ class TestRESTObject: assert fake_manager == obj.manager assert fake_gitlab == obj.manager.gitlab + def test_instantiate_non_dict(self, fake_gitlab, fake_manager): + with pytest.raises(gitlab.exceptions.GitlabParsingError): + FakeObject(fake_manager, ["a", "list", "fails"]) + def test_picklability(self, fake_manager): obj = FakeObject(fake_manager, {"foo": "bar"}) original_obj_module = obj._module |