diff options
| author | John L. Villalovos <john@sodarock.com> | 2021-12-30 12:34:50 -0800 |
|---|---|---|
| committer | John L. Villalovos <john@sodarock.com> | 2021-12-30 12:34:50 -0800 |
| commit | cb824a49af9b0d155b89fe66a4cfebefe52beb7a (patch) | |
| tree | e2227ebe783649de4c4b8a1b45ac4a9bc9e18a6a /tests/unit/test_gitlab.py | |
| parent | 501f9a1588db90e6d2c235723ba62c09a669b5d2 (diff) | |
| download | gitlab-jlvillal/pagination.tar.gz | |
fix: handle situation where GitLab does not return valuesjlvillal/pagination
If a query returns more than 10,000 records than the following values
are NOT returned:
x.total_pages
x.total
Modify the code to allow no value to be set for these values. If there
is not a value returned the functions will now return None.
Update unit test so no longer `xfail`
https://docs.gitlab.com/ee/user/gitlab_com/index.html#pagination-response-headers
Closes #1686
Diffstat (limited to 'tests/unit/test_gitlab.py')
| -rw-r--r-- | tests/unit/test_gitlab.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tests/unit/test_gitlab.py b/tests/unit/test_gitlab.py index 2981ebb..4d742d3 100644 --- a/tests/unit/test_gitlab.py +++ b/tests/unit/test_gitlab.py @@ -16,9 +16,9 @@ # You should have received a copy of the GNU Lesser General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. +import copy import pickle import warnings -from copy import deepcopy import pytest import responses @@ -109,7 +109,7 @@ def _strip_pagination_headers(response): """ https://docs.gitlab.com/ee/user/gitlab_com/index.html#pagination-response-headers """ - stripped = deepcopy(response) + stripped = copy.deepcopy(response) del stripped["headers"]["X-Total-Pages"] del stripped["headers"]["X-Total"] @@ -117,7 +117,6 @@ def _strip_pagination_headers(response): return stripped -@pytest.mark.xfail(reason="See #1686") @responses.activate def test_gitlab_build_list_missing_headers(gl, resp_page_1, resp_page_2): stripped_page_1 = _strip_pagination_headers(resp_page_1) |