From 18415fe34f44892da504ec578ea35e74f0d78565 Mon Sep 17 00:00:00 2001
From: Gauvain Pocentek <gauvain@pocentek.net>
Date: Mon, 2 Jan 2017 09:14:20 +0100
Subject: Forbid empty id for get()

Unless the class explicitly defines it's OK (getRequiresId set to True).
---
 gitlab/objects.py | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'gitlab')

diff --git a/gitlab/objects.py b/gitlab/objects.py
index 2a33dc5..4088661 100644
--- a/gitlab/objects.py
+++ b/gitlab/objects.py
@@ -99,6 +99,8 @@ class BaseManager(object):
         args = self._set_parent_args(**kwargs)
         if not self.obj_cls.canGet:
             raise NotImplementedError
+        if id is None and self.obj_cls.getRequiresId is True:
+            raise ValueError('The id argument must be defined.')
         return self.obj_cls.get(self.gitlab, id, **args)
 
     def list(self, **kwargs):
-- 
cgit v1.2.1