[registry] RegistrableInstance should be instantiated with __module__=__name__

To detect in whih module the instance was created we previously detect the
filename in python stack and then use modpath_from_file(). Since the later is
now deprecated, we should force passing the module at instantiation with
__module__=__name__.

Deprecate old usage

1 files changed, 13 insertions, 3 deletions

diff --git a/logilab/common/registry.py b/logilab/common/registry.py
index 476bef8..83f467b 100644
--- a/logilab/common/registry.py
+++ b/logilab/common/registry.py
@@ -212,12 +212,22 @@ class RegistrableInstance(RegistrableObject):
         """Add a __module__ attribute telling the module where the instance was
         created, for automatic registration.
         """
+        module = kwargs.pop('__module__', None)
         obj = super(RegistrableInstance, cls).__new__(cls)
-        # XXX subclass must no override __new__
-        filepath = tb.extract_stack(limit=2)[0][0]
-        obj.__module__ = _modname_from_path(filepath)
+        if module is None:
+            warn('instantiate {0} with '
+                 '__module__=__name__'.format(cls.__name__),
+                 DeprecationWarning)
+            # XXX subclass must no override __new__
+            filepath = tb.extract_stack(limit=2)[0][0]
+            obj.__module__ = _modname_from_path(filepath)
+        else:
+            obj.__module__ = module
         return obj
 
+    def __init__(self, __module__=None):
+        super(RegistrableInstance, self).__init__()
+
 
 class Registry(dict):
     """The registry store a set of implementations associated to identifier: