summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexei Romanoff <drednout.by@gmail.com>2012-10-12 13:19:53 +0300
committerAlexei Romanoff <drednout.by@gmail.com>2012-10-12 13:19:53 +0300
commitcf89f18be7614d6d55bb9eb7e9bf0e10d42a8508 (patch)
treee8896d1a6e740edd28551c6f0320f356b58c512e
parent4ea952f39dc5ff1231f780252d8d4efb16b2be3b (diff)
downloadmsgpack-python-cf89f18be7614d6d55bb9eb7e9bf0e10d42a8508.tar.gz
segfault fixed when data is unpacked using `list_hook`,
this bug is a twin to #28. Unit-test is also attached.
-rw-r--r--msgpack/unpack.h2
-rw-r--r--msgpack/unpack_template.h2
-rw-r--r--test/test_obj.py8
3 files changed, 11 insertions, 1 deletions
diff --git a/msgpack/unpack.h b/msgpack/unpack.h
index 61e5d91..3dc88e5 100644
--- a/msgpack/unpack.h
+++ b/msgpack/unpack.h
@@ -163,6 +163,8 @@ static inline int template_callback_array_end(unpack_user* u, msgpack_unpack_obj
{
if (u->list_hook) {
PyObject *new_c = PyEval_CallFunction(u->list_hook, "(O)", *c);
+ if (!new_c)
+ return -1;
Py_DECREF(*c);
*c = new_c;
}
diff --git a/msgpack/unpack_template.h b/msgpack/unpack_template.h
index 9d13062..8a57f0d 100644
--- a/msgpack/unpack_template.h
+++ b/msgpack/unpack_template.h
@@ -347,7 +347,7 @@ _push:
if(construct_cb(_array_item)(user, c->count, &c->obj, obj) < 0) { goto _failed; }
if(++c->count == c->size) {
obj = c->obj;
- construct_cb(_array_end)(user, &obj);
+ if (construct_cb(_array_end)(user, &obj) < 0) { goto _failed; }
--top;
/*printf("stack pop %d\n", top);*/
goto _push;
diff --git a/test/test_obj.py b/test/test_obj.py
index 15e192c..1d9024b 100644
--- a/test/test_obj.py
+++ b/test/test_obj.py
@@ -62,5 +62,13 @@ def test_an_exception_in_objecthook1():
packed = packb({1: {'__complex__': True, 'real': 1, 'imag': 2}})
unpackb(packed, object_hook=bad_complex_decoder)
+
+@raises(DecodeError)
+def test_an_exception_in_objecthook2():
+ packed = packb({1: [{'__complex__': True, 'real': 1, 'imag': 2}]})
+ unpackb(packed, list_hook=bad_complex_decoder, use_list=1)
+
+
+
if __name__ == '__main__':
main()