summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHood Chatham <roberthoodchatham@gmail.com>2022-03-31 08:06:17 -0700
committerCharles Harris <charlesr.harris@gmail.com>2022-03-31 13:37:10 -0600
commit543e135a6f9cbd5e88ae60085137675604ae9401 (patch)
treeaa61abe74b8d2d2f94841557fd44822a947c0cf4
parentf1c10142020b958f2289db4c8d0e5a942c98f2f9 (diff)
downloadnumpy-543e135a6f9cbd5e88ae60085137675604ae9401.tar.gz
Use description from mattip
-rw-r--r--doc/release/upcoming_changes/21154.improvement.rst30
1 files changed, 7 insertions, 23 deletions
diff --git a/doc/release/upcoming_changes/21154.improvement.rst b/doc/release/upcoming_changes/21154.improvement.rst
index 5ff2a3ebf..38630b47b 100644
--- a/doc/release/upcoming_changes/21154.improvement.rst
+++ b/doc/release/upcoming_changes/21154.improvement.rst
@@ -1,23 +1,7 @@
-Math C library feature detection now works for wasm
----------------------------------------------------
-The previous feature detection generated C stubs like:
-
-.. code-block:: C
-
- void exp(void); // incorrect signature!
- exp();
-
-Then checked whether compiling and linking these worked. This generates warnings
-that complain that ``exp`` actually has signature ``double exp(double)`` but would
-otherwise work. However ``wasm-ld`` creates a hard error in this case, so when
-compiling to a wasm target everything is detected as missing.
-
-This is now fixed: we feature detect instead with code like:
-
-.. code-block:: C
-
- double exp(double); // correct signature!
- exp((double)0);
-
-which ``wasm-ld`` will link. As a side effect, the feature detection code now
-works without generating linker warnings.
+Math C library feature detection now uses correct signatures
+------------------------------------------------------------
+Compiling is preceded by a detection phase to determine whether the
+underlying libc supports certain math operations. Previously this code
+did not respect the proper signatures. Fixing this enables compilation
+for the ``wasm-ld`` backend (compilation for web assembly) and reduces
+the number of warnings.