summaryrefslogtreecommitdiff
path: root/pecan
diff options
context:
space:
mode:
Diffstat (limited to 'pecan')
-rw-r--r--pecan/core.py17
-rw-r--r--pecan/tests/test_hooks.py30
2 files changed, 43 insertions, 4 deletions
diff --git a/pecan/core.py b/pecan/core.py
index c09763d..29930b6 100644
--- a/pecan/core.py
+++ b/pecan/core.py
@@ -299,7 +299,11 @@ class Pecan(object):
hooks = reversed(state.hooks)
for hook in hooks:
- getattr(hook, hook_type)(*args)
+ result = getattr(hook, hook_type)(*args)
+ # on_error hooks can choose to return a Response, which will
+ # be used instead of the standard error pages.
+ if hook_type == 'on_error' and isinstance(result, Response):
+ return result
def get_args(self, req, all_params, remainder, argspec, im_self):
'''
@@ -564,11 +568,16 @@ class Pecan(object):
environ['pecan.original_exception'] = e
# if this is not an internal redirect, run error hooks
+ on_error_result = None
if not isinstance(e, ForwardRequestException):
- self.handle_hooks('on_error', state, e)
+ on_error_result = self.handle_hooks('on_error', state, e)
- if not isinstance(e, exc.HTTPException):
- raise
+ # if the on_error handler returned a Response, use it.
+ if isinstance(on_error_result, Response):
+ state.response = on_error_result
+ else:
+ if not isinstance(e, exc.HTTPException):
+ raise
finally:
# handle "after" hooks
self.handle_hooks('after', state)
diff --git a/pecan/tests/test_hooks.py b/pecan/tests/test_hooks.py
index 66947ca..246af76 100644
--- a/pecan/tests/test_hooks.py
+++ b/pecan/tests/test_hooks.py
@@ -1,7 +1,10 @@
from webtest import TestApp
from six import b as b_
+from six import u as u_
from six.moves import cStringIO as StringIO
+from webob import Response
+
from pecan import make_app, expose, redirect, abort
from pecan.hooks import (
PecanHook, TransactionHook, HookController, RequestViewerHook
@@ -133,6 +136,33 @@ class TestHooks(PecanTestCase):
assert run_hook[0] == 'on_route'
assert run_hook[1] == 'error'
+ def test_on_error_response_hook(self):
+ run_hook = []
+
+ class RootController(object):
+ @expose()
+ def causeerror(self):
+ return [][1]
+
+ class ErrorHook(PecanHook):
+ def on_error(self, state, e):
+ run_hook.append('error')
+
+ r = Response()
+ r.text = u_('on_error')
+
+ return r
+
+ app = TestApp(make_app(RootController(), hooks=[
+ ErrorHook()
+ ]))
+
+ response = app.get('/causeerror')
+
+ assert len(run_hook) == 1
+ assert run_hook[0] == 'error'
+ assert response.text == 'on_error'
+
def test_prioritized_hooks(self):
run_hook = []