diff options
author | Jacob MacDonald <jaccarmac@gmail.com> | 2015-10-29 14:11:07 -0600 |
---|---|---|
committer | Jacob MacDonald <jaccarmac@gmail.com> | 2015-10-29 14:11:07 -0600 |
commit | eaff751319592db73271408d6ac282e00a1deaf3 (patch) | |
tree | 6d2157896ec2862779b88e5cf82689e63acc1a21 | |
parent | 72e76ab03bd8ea27196ec6c6aa609c4a9ddd0d38 (diff) | |
download | pep8-eaff751319592db73271408d6ac282e00a1deaf3.tar.gz |
Correct _get_parameters.
The two versions of parameter parsing were not, in fact, equivalent. The
return types of `inspect.signature` and `inspect.getargspec` are, in
fact, subtly different.
See:
* https://docs.python.org/3/library/inspect.html#inspect.signature
* https://github.com/praw-dev/praw/issues/541#issuecomment-152280322
-rwxr-xr-x | pep8.py | 5 |
1 files changed, 4 insertions, 1 deletions
@@ -1316,7 +1316,10 @@ _checks = {'physical_line': {}, 'logical_line': {}, 'tree': {}} def _get_parameters(function): if sys.version_info >= (3, 3): - return list(inspect.signature(function).parameters) + return [parameter.name + for parameter + in inspect.signature(function).parameters.values() + if parameter.kind == parameter.POSITIONAL_OR_KEYWORD] else: return inspect.getargspec(function)[0] |