summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--.travis.yml2
-rw-r--r--CHANGES.txt3
-rwxr-xr-xpep8.py2
-rw-r--r--testsuite/E25.py5
4 files changed, 11 insertions, 1 deletions
diff --git a/.travis.yml b/.travis.yml
index a37c115..b188325 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,6 +6,7 @@ python:
- 3.3
- 3.4
- pypy
+ - pypy3
install:
- pip install -e .
- pip list
@@ -17,6 +18,7 @@ script:
matrix:
allow_failures:
- python: pypy
+ - python: pypy3
notifications:
email:
diff --git a/CHANGES.txt b/CHANGES.txt
index 657ada9..c57bfd1 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -36,6 +36,9 @@ Bug fixes:
* Don't crash if os.path.expanduser() throws an ImportError. (Issue #297)
+* Missing space around keyword parameter equal not always reported, E251.
+ (Issue #323)
+
* Fix false positive E711/E712/E713. (Issues #330 and #336)
diff --git a/pep8.py b/pep8.py
index 338b434..c8889b5 100755
--- a/pep8.py
+++ b/pep8.py
@@ -769,7 +769,7 @@ def whitespace_around_named_parameter_equals(logical_line, tokens):
no_space = False
if start != prev_end:
yield (prev_end, message)
- elif token_type == tokenize.OP:
+ if token_type == tokenize.OP:
if text == '(':
parens += 1
elif text == ')':
diff --git a/testsuite/E25.py b/testsuite/E25.py
index 37d0d42..9b7ff69 100644
--- a/testsuite/E25.py
+++ b/testsuite/E25.py
@@ -17,6 +17,11 @@ parser.add_argument('--long-option',
#: E251:1:45
parser.add_argument('--long-option', default
="/rather/long/filesystem/path/here/blah/blah/blah")
+#: E251:3:8 E251:3:10
+foo(True,
+ baz=(1, 2),
+ biz = 'foo'
+ )
#: Okay
foo(bar=(1 == 1))
foo(bar=(1 != 1))