From 0327e55e756e20ade468e67992f9f43da14aabb4 Mon Sep 17 00:00:00 2001 From: Anthony Sottile Date: Fri, 1 Mar 2019 08:22:55 -0800 Subject: Fix E721 false positive --- pycodestyle.py | 2 +- testsuite/E72.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pycodestyle.py b/pycodestyle.py index 02a717a..cad68ea 100755 --- a/pycodestyle.py +++ b/pycodestyle.py @@ -139,7 +139,7 @@ WHITESPACE_AFTER_COMMA_REGEX = re.compile(r'[,;:]\s*(?: |\t)') COMPARE_SINGLETON_REGEX = re.compile(r'(\bNone|\bFalse|\bTrue)?\s*([=!]=)' r'\s*(?(1)|(None|False|True))\b') COMPARE_NEGATIVE_REGEX = re.compile(r'\b(not)\s+[^][)(}{ ]+\s+(in|is)\s') -COMPARE_TYPE_REGEX = re.compile(r'(?:[=!]=|is(?:\s+not)?)\s*type(?:s.\w+Type' +COMPARE_TYPE_REGEX = re.compile(r'(?:[=!]=|is(?:\s+not)?)\s+type(?:s.\w+Type' r'|\s*\(\s*([^)]*[^ )])\s*\))') KEYWORD_REGEX = re.compile(r'(\s*)\b(?:%s)\b(\s*)' % r'|'.join(KEYWORDS)) OPERATOR_REGEX = re.compile(r'(?:[^,\s])(\s*)(?:[-+*/|!<=>%&^]+)(\s*)') diff --git a/testsuite/E72.py b/testsuite/E72.py index c18527f..a60d892 100644 --- a/testsuite/E72.py +++ b/testsuite/E72.py @@ -49,6 +49,9 @@ if isinstance(res, types.MethodType): pass if type(a) != type(b) or type(a) == type(ccc): pass +#: Okay +def func_histype(a, b, c): + pass #: E722 try: pass -- cgit v1.2.1