From cfa24ab02e24914038c55286dbb2f19d1ccf9a31 Mon Sep 17 00:00:00 2001 From: Ian Lee Date: Mon, 12 Jan 2015 23:45:03 -0800 Subject: Reduce calls to sys.stdout.flush() from 3 to 1; issue #363 --- pep8.py | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/pep8.py b/pep8.py index 9d3b091..77c5df0 100755 --- a/pep8.py +++ b/pep8.py @@ -1681,13 +1681,6 @@ class StandardReport(BaseReport): 'row': self.line_offset + line_number, 'col': offset + 1, 'code': code, 'text': text, }) - # stdout is block buffered when not stdout.isatty(). - # When using pep8 in multiprocess, line can be broken where - # buffer boundary since other processes write to same file. - # So flush() after print() to avoid buffer boundary. - # Typical buffer size is 8192. line written safely when - # len(line) < 8192. - sys.stdout.flush() if self._show_source: if line_number > len(self.lines): line = '' @@ -1695,10 +1688,16 @@ class StandardReport(BaseReport): line = self.lines[line_number - 1] print(line.rstrip()) print(re.sub(r'\S', ' ', line[:offset]) + '^') - sys.stdout.flush() if self._show_pep8 and doc: print(' ' + doc.strip()) - sys.stdout.flush() + + # stdout is block buffered when not stdout.isatty(). + # line can be broken where buffer boundary since other processes + # write to same file. + # flush() after print() to avoid buffer boundary. + # Typical buffer size is 8192. line written safely when + # len(line) < 8192. + sys.stdout.flush() return self.file_errors -- cgit v1.2.1