summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGiampaolo Rodola <g.rodola@gmail.com>2020-02-13 13:55:12 -0800
committerGiampaolo Rodola <g.rodola@gmail.com>2020-02-13 13:55:12 -0800
commit649ca88ea06f587d51117daa6295ae027d836d05 (patch)
tree9164e0cc77da4186bdfa00f27705b4a69b40b49b
parente92f011300a0dcc66559255f57cda4a0bfbdc2be (diff)
downloadpsutil-649ca88ea06f587d51117daa6295ae027d836d05.tar.gz
remove cache for proc_times(): unnecessary because create_time() is already cached
-rw-r--r--psutil/_pswindows.py13
1 files changed, 4 insertions, 9 deletions
diff --git a/psutil/_pswindows.py b/psutil/_pswindows.py
index 3b51dabf..99d5d714 100644
--- a/psutil/_pswindows.py
+++ b/psutil/_pswindows.py
@@ -722,12 +722,10 @@ class Process(object):
def oneshot_enter(self):
self._proc_info.cache_activate(self)
- self._proc_times.cache_activate(self)
self.exe.cache_activate(self)
def oneshot_exit(self):
self._proc_info.cache_deactivate(self)
- self._proc_times.cache_deactivate(self)
self.exe.cache_deactivate(self)
@memoize_when_activated
@@ -739,11 +737,6 @@ class Process(object):
assert len(ret) == len(pinfo_map)
return ret
- @memoize_when_activated
- def _proc_times(self):
- user, system, created = cext.proc_times(self.pid)
- return (user, system, created)
-
def name(self):
"""Return process name, which on Windows is always the final
part of the executable.
@@ -934,8 +927,10 @@ class Process(object):
@wrap_exceptions
def create_time(self):
+ # Note: proc_times() not put under oneshot() 'cause create_time()
+ # is already cached by the main Process class.
try:
- user, system, created = self._proc_times()
+ user, system, created = cext.proc_times(self.pid)
return created
except OSError as err:
if is_permission_err(err):
@@ -958,7 +953,7 @@ class Process(object):
@wrap_exceptions
def cpu_times(self):
try:
- user, system, created = self._proc_times()
+ user, system, created = cext.proc_times(self.pid)
except OSError as err:
if not is_permission_err(err):
raise