fix #906 / disk_partitions(): ignore 'all' parameter and return all partitions

3 files changed, 11 insertions, 7 deletions

diff --git a/HISTORY.rst b/HISTORY.rst
index a429ce65..128fdadc 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -22,6 +22,8 @@ Bug tracker at https://github.com/giampaolo/psutil/issues
   functions.
 - #892: [Linux] Process.cpu_affinity([-1]) raise SystemError with no error
   set; now ValueError is raised.
+- #906: [BSD] disk_partitions(all=False) returned an empty list. Now the
+  argument is ignored and all partitions are always returned.
 
 
 4.3.1 - 2016-09-01
diff --git a/docs/index.rst b/docs/index.rst
index c5d7c749..cfd3ab37 100644
--- a/docs/index.rst
+++ b/docs/index.rst
@@ -254,9 +254,12 @@ Disks
 
   Return all mounted disk partitions as a list of namedtuples including device,
   mount point and filesystem type, similarly to "df" command on UNIX. If *all*
-  parameter is ``False`` return physical devices only (e.g. hard disks, cd-rom
-  drives, USB keys) and ignore all others (e.g. memory partitions such as
+  parameter is ``False`` it tries to distinguish and return physical devices
+  only (e.g. hard disks, cd-rom drives, USB keys) and ignore all others
+  (e.g. memory partitions such as
   `/dev/shm <http://www.cyberciti.biz/tips/what-is-devshm-and-its-practical-usage.html>`__).
+  Note that this may not be fully reliable on all systems (e.g. on BSD this
+  parameter is ignored).
   Namedtuple's **fstype** field is a string which varies depending on the
   platform.
   On Linux it can be one of the values found in /proc/filesystems (e.g.
diff --git a/psutil/_psbsd.py b/psutil/_psbsd.py
index f868a212..daa140ed 100644
--- a/psutil/_psbsd.py
+++ b/psutil/_psbsd.py
@@ -283,15 +283,14 @@ def cpu_stats():
 
 
 def disk_partitions(all=False):
+    """Return mounted disk partitions as a list of namedtuples.
+    'all' argument is ignored, see:
+    https://github.com/giampaolo/psutil/issues/906
+    """
     retlist = []
     partitions = cext.disk_partitions()
     for partition in partitions:
         device, mountpoint, fstype, opts = partition
-        if device == 'none':
-            device = ''
-        if not all:
-            if not os.path.isabs(device) or not os.path.exists(device):
-                continue
         ntuple = _common.sdiskpart(device, mountpoint, fstype, opts)
         retlist.append(ntuple)
     return retlist