summaryrefslogtreecommitdiff
path: root/scripts
Commit message (Collapse)AuthorAgeFilesLines
...
* | refactor scripts using cursesGiampaolo Rodola2020-10-083-65/+117
| |
* | update personal site URLGiampaolo Rodola2020-06-161-1/+1
| |
* | Wheels6 (#1767)Giampaolo Rodola2020-05-254-179/+148
|/
* Wheels 3 (#1764)Giampaolo Rodola2020-05-231-8/+6
|
* Wheels2 (#1761)Giampaolo Rodola2020-05-182-1/+155
|
* rename memleaks scriptGiampaolo Rodola2020-05-131-1/+1
|
* Memory leak test: take fluctuations into account (#1757)Giampaolo Rodola2020-05-131-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Preamble ======= We have a [memory leak test suite](https://github.com/giampaolo/psutil/blob/e1ea2bccf8aea404dca0f79398f36f37217c45f6/psutil/tests/__init__.py#L897), which calls a function many times and fails if the process memory increased. We do this in order to detect missing `free()` or `Py_DECREF` calls in the C modules. When we do, then we have a memory leak. The problem ========== A problem we've been having for probably over 10 years, is the false positives. That's because the memory fluctuates. Sometimes it may increase (or even decrease!) due to how the OS handles memory, the Python's garbage collector, the fact that RSS is an approximation and who knows what else. So thus far we tried to compensate that by using the following logic: - warmup (call fun 10 times) - call the function many times (1000) - if memory increased before/after calling function 1000 times, then keep calling it for another 3 secs - if it still increased at all (> 0) then fail This logic didn't really solve the problem, as we still had occasional false positives, especially lately on FreeBSD. The solution ========= This PR changes the internal algorithm so that in case of failure (mem > 0 after calling fun() N times) we retry the test for up to 5 times, increasing N (repetitions) each time, so we consider it a failure only if the memory **keeps increasing** between runs. So for instance, here's a legitimate failure: ``` psutil.tests.test_memory_leaks.TestModuleFunctionsLeaks.test_disk_partitions ... Run #1: extra-mem=696.0K, per-call=3.5K, calls=200 Run #2: extra-mem=1.4M, per-call=3.5K, calls=400 Run #3: extra-mem=2.1M, per-call=3.5K, calls=600 Run #4: extra-mem=2.7M, per-call=3.5K, calls=800 Run #5: extra-mem=3.4M, per-call=3.5K, calls=1000 FAIL ``` If, on the other hand, the memory increased on one run (say 200 calls) but decreased on the next run (say 400 calls), then it clearly means it's a false positive, because memory consumption may be > 0 on second run, but if it's lower than the previous run with less repetitions, then it cannot possibly represent a leak (just a fluctuation): ``` psutil.tests.test_memory_leaks.TestModuleFunctionsLeaks.test_net_connections ... Run #1: extra-mem=568.0K, per-call=2.8K, calls=200 Run #2: extra-mem=24.0K, per-call=61.4B, calls=400 OK ``` Note about mallinfo() ================ Aka #1275. `mallinfo()` on Linux is supposed to provide memory metrics about how many bytes gets allocated on the heap by `malloc()`, so it's supposed to be way more precise than RSS and also [USS](http://grodola.blogspot.com/2016/02/psutil-4-real-process-memory-and-environ.html). In another branch were I exposed it, I verified that fluctuations still occur even when using `mallinfo()` though, despite less often. So that means even `mallinfo()` would not grant 100% stability.
* Add new TestFdsLeak test class (#1752)Giampaolo Rodola2020-05-062-0/+8
|
* fix some memleak tests on winGiampaolo Rodola2020-05-051-2/+2
|
* Drastically improve "make test/build" speed.Giampaolo Rodola2020-05-012-15/+15
| | | | | | | Doing "make install" before any test is slow and not really necessary. Instead do "make build", and remove the part import setuptools and test psutil can be imported (do that in make install instead). This way I went down from 0.8 secs (install phase before starting the test) to 0.3 secs!
* Per-test file cleanup and new PsutilTestCase (#1743)Giampaolo Rodola2020-04-301-8/+5
| | | | | Test files/dirs are now removed after each test. when invoked via self.get_testfn(). Until now test files were stored in a global variable and were removed at process exit, via atexit.register(), but this didn't work with parallel tests because the fork()ed workers use os._exit(0), preventing cleanup functions to run. All test classes now inherit from PsutilTestCase class, which provides the most important methods requiring an automatic cleanup (get_test_subprocess() and others).
* Parallel build (#1741)Giampaolo Rodola2020-04-301-5/+6
|
* MemoryLeakTest class enhancements (#1731)Giampaolo Rodola2020-04-232-2/+0
|
* Git hook for renamed/added/deleted files + flake8 print() + tidelift (#1704)Giampaolo Rodola2020-02-215-136/+190
|
* Add C linter script (#1698)Giampaolo Rodola2020-02-183-4/+92
|
* get rid of pip_install() code for py2; move everything in runner.pyGiampaolo Rodola2020-02-151-1/+1
|
* point all shebangs to python 3Giampaolo Rodola2020-02-1534-35/+35
|
* refactor print colors utilsGiampaolo Rodola2020-02-154-106/+28
|
* update docGiampaolo Rodola2020-02-154-4/+4
|
* fix #1688: use python3 in GIT commit hook hashbangGiampaolo Rodola2020-02-131-1/+1
|
* Add support for PyPy on Windows (#1686)Giampaolo Rodola2020-02-111-3/+9
|
* [Windows] connections() refactoring (#1678)Giampaolo Rodola2020-02-011-1/+1
|
* AD script: print AD percentage + elapsed timeGiampaolo Rodola2020-01-161-2/+7
|
* properly cleanup C threadGiampaolo Rodola2020-01-141-0/+2
|
* exec make install before 2 targetsGiampaolo Rodola2020-01-141-0/+2
|
* fix some win testsGiampaolo Rodola2020-01-061-1/+1
|
* winmake.py: use argparseGiampaolo Rodola2020-01-061-114/+84
|
* winmake.py: accept builtiple targets/argsGiampaolo Rodola2020-01-031-9/+12
|
* winmake / uninstall: remove installation path from easy-install.pth fileGiampaolo Rodola2020-01-021-0/+18
|
* Drop windows XP support (#1652)Giampaolo Rodola2020-01-011-1/+0
| | | | minimum supported now is Windows Vista
* highlight cmd.exe warnings/errs from VSGiampaolo Rodola2019-12-301-1/+53
|
* #fix #1595 / windows: kill() may not raise AccessDeniedGiampaolo Rodola2019-11-201-1/+1
|
* revert last appveyor change for 3.8Giampaolo Rodola2019-10-241-1/+1
|
* appveyor: add python 3.8; drop 3.5Giampaolo Rodola2019-10-211-1/+1
|
* fix #1578: 'perf' lib was renamed to 'pyperf'Giampaolo Rodola2019-09-182-3/+3
|
* Merge branch 'master' of github.com:giampaolo/psutilGiampaolo Rodola2019-09-151-1/+1
|\
| * typo fix scripts/internal/print_timeline.py (#1556)SteveMoto2019-08-271-1/+1
| |
* | add script to help fix flake8 issuesGiampaolo Rodola2019-06-291-0/+185
|/
* credits to @wiggin15 for #1528Giampaolo Rodola2019-06-121-2/+2
|
* Fix some tests on AIX (#1507)wiggin152019-05-081-1/+3
|
* update docGiampaolo Rodola2019-04-121-2/+1
|
* improve pmap.py scriptGiampaolo Rodola2019-04-052-7/+8
|
* reuse ps.py script in psutil.test()Giampaolo Rodola2019-04-051-2/+22
|
* move get_terminal_size() in _compat.pyGiampaolo Rodola2019-04-052-41/+26
|
* improve ps.py scriptGiampaolo Rodola2019-04-051-25/+6
|
* improve ps.py scriptGiampaolo Rodola2019-04-051-27/+24
|
* move bytes2human() into psutil._common and reused it from scripts dirGiampaolo Rodola2019-04-059-214/+79
|
* merge from masterGiampaolo Rodola2019-04-051-1/+2
|
* fix #1478: add make command to re-run tests failed on last runGiampaolo Rodola2019-04-051-0/+10
|
* fix #1463: cpu_distribution.py script is brokenGiampaolo Rodola2019-03-171-7/+35
|
View Lorry Controller Status