Dropped possible wrong code path in conn_decode

It shouldn't happen for both cdecoder and pydecoder to be null,
but just in case...

1 files changed, 15 insertions, 13 deletions

diff --git a/psycopg/connection_int.c b/psycopg/connection_int.c
index a60c4a9..7f6b755 100644
--- a/psycopg/connection_int.c
+++ b/psycopg/connection_int.c
@@ -121,10 +121,6 @@ exit:
 PyObject *
 conn_decode(connectionObject *self, const char *str, Py_ssize_t len)
 {
-    PyObject *b = NULL;
-    PyObject *t = NULL;
-    PyObject *rv = NULL;
-
     if (len < 0) { len = strlen(str); }
 
     if (self) {
@@ -132,22 +128,28 @@ conn_decode(connectionObject *self, const char *str, Py_ssize_t len)
             return self->cdecoder(str, len, NULL);
         }
         else if (self->pydecoder) {
-            if (!(b = Bytes_FromStringAndSize(str, len))) { goto exit; }
+            PyObject *b = NULL;
+            PyObject *t = NULL;
+            PyObject *rv = NULL;
+
+            if (!(b = Bytes_FromStringAndSize(str, len))) { goto error; }
             if (!(t = PyObject_CallFunctionObjArgs(self->pydecoder, b, NULL))) {
-                goto exit;
+                goto error;
             }
-            rv = PyTuple_GetItem(t, 0);
-            Py_XINCREF(rv);
+            if (!(rv = PyTuple_GetItem(t, 0))) { goto error; }
+            Py_INCREF(rv);      /* PyTuple_GetItem gives a borrowes one */
+error:
+            Py_XDECREF(t);
+            Py_XDECREF(b);
+            return rv;
+        }
+        else {
+            return PyUnicode_FromStringAndSize(str, len);
         }
     }
     else {
         return PyUnicode_FromStringAndSize(str, len);
     }
-
-exit:
-    Py_XDECREF(t);
-    Py_XDECREF(b);
-    return rv;
 }
 
 /* conn_notice_callback - process notices */