Fixed refcount handling in encrypt_password

Added tests to check bad types, which discovered the above problem: on
type error we would have decref'd on exit something that was only
borrowed (because we wouldn't have performed matching increfs).

1 files changed, 11 insertions, 0 deletions

diff --git a/tests/test_connection.py b/tests/test_connection.py
index 7861ab7..13635f1 100755
--- a/tests/test_connection.py
+++ b/tests/test_connection.py
@@ -1482,6 +1482,17 @@ class TestEncryptPassword(ConnectingTestCase):
                 password='psycopg2', user='ashesh',
                 scope=self.conn, algorithm='scram-sha-256')
 
+    def test_bad_types(self):
+        self.assertRaises(TypeError, ext.encrypt_password)
+        self.assertRaises(TypeError, ext.encrypt_password,
+            'password', 42, self.conn, 'md5')
+        self.assertRaises(TypeError, ext.encrypt_password,
+            42, 'user', self.conn, 'md5')
+        self.assertRaises(TypeError, ext.encrypt_password,
+            42, 'user', 'wat', 'abc')
+        self.assertRaises(TypeError, ext.encrypt_password,
+            'password', 'user', 'wat', 42)
+
 
 class AutocommitTests(ConnectingTestCase):
     def test_closed(self):