diff options
Diffstat (limited to 'pipermail/pycrypto/2011q1/000420.html')
| -rw-r--r-- | pipermail/pycrypto/2011q1/000420.html | 103 |
1 files changed, 103 insertions, 0 deletions
diff --git a/pipermail/pycrypto/2011q1/000420.html b/pipermail/pycrypto/2011q1/000420.html new file mode 100644 index 0000000..d5b8cae --- /dev/null +++ b/pipermail/pycrypto/2011q1/000420.html @@ -0,0 +1,103 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [pycrypto] Py3k changes - rebase + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:pycrypto%40lists.dlitz.net?Subject=%5Bpycrypto%5D%20Py3k%20changes%20-%20rebase&In-Reply-To=20110130023127.GA2710%40rivest.dlitz.net"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="000417.html"> + <LINK REL="Next" HREF="000421.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[pycrypto] Py3k changes - rebase</H1> + <B>Thorsten Behrens</B> + <A HREF="mailto:pycrypto%40lists.dlitz.net?Subject=%5Bpycrypto%5D%20Py3k%20changes%20-%20rebase&In-Reply-To=20110130023127.GA2710%40rivest.dlitz.net" + TITLE="[pycrypto] Py3k changes - rebase">sbehrens at gmx.li + </A><BR> + <I>Sat Feb 19 06:05:28 CST 2011</I> + <P><UL> + <LI>Previous message: <A HREF="000417.html">[pycrypto] Initial review of Thorsten's Py3k changes +</A></li> + <LI>Next message: <A HREF="000421.html">[pycrypto] Py3k changes - rebase +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#420">[ date ]</a> + <a href="thread.html#420">[ thread ]</a> + <a href="subject.html#420">[ subject ]</a> + <a href="author.html#420">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>Dwayne, + + +><i> No, each commit should be a distinct change (and each distinct change +</I>><i> should have its own commit). Having separate commits for the following +</I>><i> makes sense: +</I>><i> +</I>><i> - Replace tabs with spaces +</I>><i> - Py3K _fastmath.c support +</I>><i> - Change _fastmath.c to compile with VC++ +</I>><i> - add MPIR support +</I>><i> - Add Ron Rivest Test +</I>><i> - Add unit tests for Crypto.Random.random +</I>><i> - Update documentation with current state of security of hash and +</I>><i> cipher functions. +</I>><i> - Update documentation with Python 3.x notes. +</I>><i> - Add unit test for AllOrNothing +</I>><i> - Fix AllOrNothing and random.sample() +</I> +I took a stab at just a portion of this, the first _fastmath.c changes. +The result is that I have a lot of conflicts, and after resolving those, +I have code that won't compile. + +I can't easily untangle these changes: The additional unit tests either +presume that the py3k compatibility layer is there, or are needed to +make the library work under py3k. + +I have a limited amount of enthusiasm for fixing that which already +works, so it fits into a neater order. Here's my compromise proposal: + +I will change the unit tests to wrap the test vectors in a different +place, instead of wrapping the literals, as we had discussed. + +And I will give you a branch with one commit that has all of the changes +that were made. + +I understand the desire for incremental commits. I can keep it in mind +in future, with the better understanding of git that I now have. For +this py3k change, though, the amount of work needed to attempt to +"unravel" the change and bring it in order is too great for me to want +to tackle it. The best I can offer is the compromise above. + +I could go on - I'll refrain. Hope to hear from you soon. + +Thorsten + + +</PRE> + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="000417.html">[pycrypto] Initial review of Thorsten's Py3k changes +</A></li> + <LI>Next message: <A HREF="000421.html">[pycrypto] Py3k changes - rebase +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#420">[ date ]</a> + <a href="thread.html#420">[ thread ]</a> + <a href="subject.html#420">[ subject ]</a> + <a href="author.html#420">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="http://lists.dlitz.net/cgi-bin/mailman/listinfo/pycrypto">More information about the pycrypto +mailing list</a><br> +</body></html> |