diff options
| author | David Pursehouse <david.pursehouse@sonymobile.com> | 2013-11-15 16:20:30 +0900 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2013-11-18 10:13:09 +0900 |
| commit | 0be72476ee0476ed992845f9ff28927be70d4752 (patch) | |
| tree | 377eb22e127539b98c8a9d76f831abbcbd73b6a9 | |
| parent | 0abd6d427f6ef38c8e7ace9b8b8de0e91a54de94 (diff) | |
| download | pygerrit-0be72476ee0476ed992845f9ff28927be70d4752.tar.gz | |
Always set sortkey in Change object
The from_json method returns None if the key does not exist
in the json data, so we don't need to check for existence of
the key when constructing the object.
This also ensures that the constructed object has a sortkey
member.
Change-Id: Ic342f8b25aeded0e999f93fa29190853354c57f0
| -rw-r--r-- | pygerrit/models.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/pygerrit/models.py b/pygerrit/models.py index 16a45d3..592ebbf 100644 --- a/pygerrit/models.py +++ b/pygerrit/models.py @@ -65,8 +65,7 @@ class Change(object): self.subject = from_json(json_data, "subject") self.url = from_json(json_data, "url") self.owner = Account.from_json(json_data, "owner") - if 'sortKey' in json_data: - self.sortkey = from_json(json_data, "sortKey") + self.sortkey = from_json(json_data, "sortKey") def __repr__(self): return u"<Change %s, %s, %s>" % (self.number, self.project, self.branch) |