diff options
author | Claudiu Popa <pcmanticore@gmail.com> | 2018-09-25 10:33:46 +0200 |
---|---|---|
committer | Claudiu Popa <pcmanticore@gmail.com> | 2018-09-25 10:33:46 +0200 |
commit | 20694325dde16377dd5e295ccdd82dffa68ce7aa (patch) | |
tree | ddfb9682139a4a5920ec00ed7e7b1510692f542c | |
parent | db5b7cde3df1eb874a414681753fe96d367f09bf (diff) | |
download | pylint-git-20694325dde16377dd5e295ccdd82dffa68ce7aa.tar.gz |
Move the type check of the target after checking for invalid star assignment targets
-rw-r--r-- | pylint/checkers/base.py | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/pylint/checkers/base.py b/pylint/checkers/base.py index af30286a3..2c918e722 100644 --- a/pylint/checkers/base.py +++ b/pylint/checkers/base.py @@ -546,16 +546,15 @@ class BasicErrorChecker(_BasicChecker): def visit_assign(self, node): # Check *a, *b = ... assign_target = node.targets[0] + # Check *a = b + if isinstance(node.targets[0], astroid.Starred): + self.add_message("invalid-star-assignment-target", node=node) + if not isinstance(assign_target, astroid.Tuple): return - if self._too_many_starred_for_tuple(assign_target): self.add_message("too-many-star-expressions", node=node) - # Check *a = b - if isinstance(node.targets[0], astroid.Starred): - self.add_message("invalid-star-assignment-target", node=node) - @utils.check_messages("star-needs-assignment-target") def visit_starred(self, node): """Check that a Starred expression is used in an assignment target.""" |