summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClaudiu Popa <pcmanticore@gmail.com>2019-10-16 12:04:28 +0200
committerClaudiu Popa <pcmanticore@gmail.com>2019-10-16 12:04:28 +0200
commit237d1107767b06119d849a46a85ac170e1f2f39d (patch)
tree955490107af165899a4d91228cb958add2354ef6
parent273412fba6b83acd524c265228638abde6411a4c (diff)
downloadpylint-git-237d1107767b06119d849a46a85ac170e1f2f39d.tar.gz
`invalid-overridden-method` takes `abc.abstractproperty` in account
Close #3150
-rw-r--r--ChangeLog4
-rw-r--r--pylint/checkers/utils.py2
-rw-r--r--tests/functional/i/invalid_overridden_method.py7
3 files changed, 11 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 308ac7256..937b0dced 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -25,6 +25,10 @@ Release date: TBA
Close #3147
+* `invalid-overridden-method` takes `abc.abstractproperty` in account
+
+ Close #3150
+
What's New in Pylint 2.4.2?
===========================
diff --git a/pylint/checkers/utils.py b/pylint/checkers/utils.py
index 87fed09f9..0480cd4f2 100644
--- a/pylint/checkers/utils.py
+++ b/pylint/checkers/utils.py
@@ -706,8 +706,6 @@ def decorated_with_property(node: astroid.FunctionDef) -> bool:
if not node.decorators:
return False
for decorator in node.decorators.nodes:
- if not isinstance(decorator, astroid.Name):
- continue
try:
if _is_property_decorator(decorator):
return True
diff --git a/tests/functional/i/invalid_overridden_method.py b/tests/functional/i/invalid_overridden_method.py
index a6a365d2a..2a85f8b22 100644
--- a/tests/functional/i/invalid_overridden_method.py
+++ b/tests/functional/i/invalid_overridden_method.py
@@ -51,3 +51,10 @@ class PropertySetter(Property):
@close.deleter
def close(self):
return None
+
+
+class AbstractProperty:
+
+ @abc.abstractproperty
+ def prop(self):
+ return