Add test for typing alias in isinstance calls (#5089)

3 files changed, 33 insertions, 0 deletions

diff --git a/ChangeLog b/ChangeLog
index 73238e1ad..c1670710e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -84,6 +84,11 @@ Release date: TBA
 
   Closes #5048
 
+* Fix false-positive ``isinstance-second-argument-not-valid-type`` with ``typing.Callable``.
+
+  Closes #3507
+  Closes #5087
+
 * ``TypingChecker``
 
   * Fix false-negative for ``deprecated-typing-alias`` and ``consider-using-alias``
diff --git a/tests/functional/r/regression/regression_3507_typing_alias_isinstance.py b/tests/functional/r/regression/regression_3507_typing_alias_isinstance.py
new file mode 100644
index 000000000..4dba85545
--- /dev/null
+++ b/tests/functional/r/regression/regression_3507_typing_alias_isinstance.py
@@ -0,0 +1,26 @@
+"""
+https://github.com/PyCQA/pylint/issues/3507
+False-positive 'isinstance-second-argument-not-valid-type'
+for typing aliases in 'isinstance' calls.
+"""
+import collections
+import collections.abc
+import typing
+
+isinstance(42, typing.Dict)
+isinstance(42, typing.Counter)
+isinstance(42, typing.Collection)
+isinstance(42, typing.Iterator)
+isinstance(42, typing.Tuple)
+isinstance(42, typing.Callable)
+isinstance(42, typing.Type)
+
+
+# For comparison - also valid calls
+isinstance(42, dict)
+isinstance(42, collections.Counter)
+isinstance(42, collections.abc.Collection)
+isinstance(42, collections.abc.Iterator)
+isinstance(42, tuple)
+isinstance(42, collections.abc.Callable)
+isinstance(42, type)
diff --git a/tests/functional/r/regression/regression_3507_typing_alias_isinstance.rc b/tests/functional/r/regression/regression_3507_typing_alias_isinstance.rc
new file mode 100644
index 000000000..a17bb22da
--- /dev/null
+++ b/tests/functional/r/regression/regression_3507_typing_alias_isinstance.rc
@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver=3.7