diff options
| author | Marc Mueller <30130371+cdce8p@users.noreply.github.com> | 2021-09-05 23:43:03 +0200 |
|---|---|---|
| committer | Marc Mueller <30130371+cdce8p@users.noreply.github.com> | 2021-09-05 23:43:03 +0200 |
| commit | 092c0dc224d855fce1f87962ec80371a55bd4a7d (patch) | |
| tree | c70d57802c3e3c2459b69bb9b4e814134de01465 | |
| parent | 005b7d22c75c7c32c1dafd7b548d858c0682e58a (diff) | |
| download | pylint-git-092c0dc224d855fce1f87962ec80371a55bd4a7d.tar.gz | |
Extend consider-using-in for attribute access
| -rw-r--r-- | ChangeLog | 2 | ||||
| -rw-r--r-- | doc/whatsnew/2.11.rst | 2 | ||||
| -rw-r--r-- | pylint/checkers/refactoring/refactoring_checker.py | 2 | ||||
| -rw-r--r-- | tests/functional/c/consider/consider_using_in.py | 9 | ||||
| -rw-r--r-- | tests/functional/c/consider/consider_using_in.txt | 1 |
5 files changed, 14 insertions, 2 deletions
@@ -63,6 +63,8 @@ Release date: TBA Closes #4907 +* Extended ``consider-using-in`` check to work for attribute access. + What's New in Pylint 2.10.3? ============================ diff --git a/doc/whatsnew/2.11.rst b/doc/whatsnew/2.11.rst index cdbba865d..72dc75e71 100644 --- a/doc/whatsnew/2.11.rst +++ b/doc/whatsnew/2.11.rst @@ -69,3 +69,5 @@ Other Changes * Fix false positive ``superfluous-parens`` for tuples created with inner tuples Closes #4907 + +* Extended ``consider-using-in`` check to work for attribute access. diff --git a/pylint/checkers/refactoring/refactoring_checker.py b/pylint/checkers/refactoring/refactoring_checker.py index 7b977d39b..525e77112 100644 --- a/pylint/checkers/refactoring/refactoring_checker.py +++ b/pylint/checkers/refactoring/refactoring_checker.py @@ -1185,7 +1185,7 @@ class RefactoringChecker(checkers.BaseTokenChecker): for value in node.values: variable_set = set() for comparable in value.left, value.ops[0][1]: - if isinstance(comparable, nodes.Name): + if isinstance(comparable, (nodes.Name, nodes.Attribute)): variable_set.add(comparable.as_string()) values.append(comparable.as_string()) variables.append(variable_set) diff --git a/tests/functional/c/consider/consider_using_in.py b/tests/functional/c/consider/consider_using_in.py index fb68ac5e6..8d23bb093 100644 --- a/tests/functional/c/consider/consider_using_in.py +++ b/tests/functional/c/consider/consider_using_in.py @@ -1,4 +1,4 @@ -# pylint: disable=missing-docstring, invalid-name, pointless-statement, misplaced-comparison-constant, undefined-variable, literal-comparison, line-too-long, unneeded-not +# pylint: disable=missing-docstring, invalid-name, pointless-statement, misplaced-comparison-constant, undefined-variable, literal-comparison, line-too-long, unneeded-not, too-few-public-methods value = value1 = 1 value2 = 2 @@ -44,3 +44,10 @@ def oops(): some_value = value == 4 or value == 5 or value == oops() # We only look for names and constants + + +# With attribute nodes +class A: + value = 2 + +A.value == 1 or A.value == 2 # [consider-using-in] diff --git a/tests/functional/c/consider/consider_using_in.txt b/tests/functional/c/consider/consider_using_in.txt index 63e5fffff..72c8e389d 100644 --- a/tests/functional/c/consider/consider_using_in.txt +++ b/tests/functional/c/consider/consider_using_in.txt @@ -11,3 +11,4 @@ consider-using-in:19:0::"Consider merging these comparisons with ""in"" to 'valu consider-using-in:20:0::"Consider merging these comparisons with ""in"" to 'value not in (1, 2)'" consider-using-in:21:0::"Consider merging these comparisons with ""in"" to 'value1 in (value2,)'" consider-using-in:22:0::"Consider merging these comparisons with ""in"" to 'a_list in ([1, 2, 3], [])'" +consider-using-in:53:0::"Consider merging these comparisons with ""in"" to 'A.value in (1, 2)'" |