summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierre Sassoulas <pierre.sassoulas@gmail.com>2021-08-21 10:41:23 +0200
committerGitHub <noreply@github.com>2021-08-21 10:41:23 +0200
commitad97338d8cadf752036498ebc724c179f61be33d (patch)
treed92e4f45c76c7e3d7f37e1f8fd7cb5ff6632ead1
parentba00fb283378fdeb58c4e2e541be711420d96849 (diff)
downloadpylint-git-ad97338d8cadf752036498ebc724c179f61be33d.tar.gz
Migrate from ``appdirs`` to ``platformdirs`` (#4887)
* Migrate from appdirs to platformdirs Closes #4886
-rw-r--r--ChangeLog6
-rw-r--r--pylint/config/__init__.py4
-rw-r--r--setup.cfg6
-rw-r--r--tests/lint/unittest_lint.py4
4 files changed, 13 insertions, 7 deletions
diff --git a/ChangeLog b/ChangeLog
index d2f9d99a0..49fc5d968 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -15,6 +15,12 @@ What's New in Pylint 2.10.2?
============================
Release date: TBA
+..
+ Put bug fixes that should not wait for a new minor version here
+
+* We now use platformdirs instead of appdirs since the latter is not maintained.
+
+ Closes #4886
What's New in Pylint 2.10.1?
diff --git a/pylint/config/__init__.py b/pylint/config/__init__.py
index c9a200315..8c85cc7fa 100644
--- a/pylint/config/__init__.py
+++ b/pylint/config/__init__.py
@@ -40,7 +40,7 @@ import pickle
import sys
from datetime import datetime
-import appdirs
+import platformdirs
from pylint.config.configuration_mixin import ConfigurationMixIn
from pylint.config.find_default_config_files import find_default_config_files
@@ -69,7 +69,7 @@ if "PYLINTHOME" in os.environ:
elif USER_HOME == "~":
PYLINT_HOME = ".pylint.d"
else:
- PYLINT_HOME = appdirs.user_cache_dir("pylint")
+ PYLINT_HOME = platformdirs.user_cache_dir("pylint")
# The spam prevention is due to pylint being used in parallel by
# pre-commit, and the message being spammy in this context
# Also if you work with old version of pylint that recreate the
diff --git a/setup.cfg b/setup.cfg
index b04fcf1f2..bdf0a8743 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -42,7 +42,7 @@ project_urls =
[options]
packages = find:
install_requires =
- appdirs>=1.4.0
+ platformdirs>=2.0.0
astroid>=2.7.2,<2.8 # (You should also upgrade requirements_test_min.txt)
isort>=4.2.5,<6
mccabe>=0.6,<0.7
@@ -75,7 +75,7 @@ markers =
[isort]
multi_line_output = 3
line_length = 88
-known_third_party = appdirs, astroid, sphinx, isort, pytest, mccabe, six, toml
+known_third_party = platformdirs, astroid, sphinx, isort, pytest, mccabe, six, toml
include_trailing_comma = True
skip_glob = tests/functional/**,tests/input/**,tests/extensions/data/**,tests/regrtest_data/**,tests/data/**,astroid/**,venv/**
src_paths = pylint
@@ -83,7 +83,7 @@ src_paths = pylint
[mypy]
scripts_are_modules = True
-[mypy-appdirs]
+[mypy-platformdirs]
ignore_missing_imports = True
[mypy-astroid.*]
diff --git a/tests/lint/unittest_lint.py b/tests/lint/unittest_lint.py
index 8c8a1c550..fee47c9cf 100644
--- a/tests/lint/unittest_lint.py
+++ b/tests/lint/unittest_lint.py
@@ -49,7 +49,7 @@ from os import chdir, getcwd
from os.path import abspath, basename, dirname, isdir, join, sep
from shutil import rmtree
-import appdirs
+import platformdirs
import pytest
from pylint import checkers, config, exceptions, interfaces, lint, testutils
@@ -635,7 +635,7 @@ def test_pylint_home():
if uhome == "~":
expected = ".pylint.d"
else:
- expected = appdirs.user_cache_dir("pylint")
+ expected = platformdirs.user_cache_dir("pylint")
assert config.PYLINT_HOME == expected
try: