diff options
| author | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2021-07-01 09:38:04 +0200 |
|---|---|---|
| committer | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2021-07-01 10:13:58 +0200 |
| commit | eff4ad891df501be4ce4179ed772fb3dddae2ace (patch) | |
| tree | 2b8e8139fb68bff754b0f4443e06bf23b1dce385 | |
| parent | 62ce45080bfd8212700184006af67112775e2570 (diff) | |
| download | pylint-git-eff4ad891df501be4ce4179ed772fb3dddae2ace.tar.gz | |
[unnecessary-dict-index-lookup] Add a test case in the functional test
Following review, see https://github.com/PyCQA/pylint/pull/4640/files/10bdef17f0b079addd9e3af90f59a0e1952cfc90#r661698900
| -rw-r--r-- | tests/functional/u/unnecessary/unnecessary_dict_index_lookup.py | 3 | ||||
| -rw-r--r-- | tests/functional/u/unnecessary/unnecessary_dict_index_lookup.txt | 27 |
2 files changed, 17 insertions, 13 deletions
diff --git a/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.py b/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.py index 68e254c16..f166e6c72 100644 --- a/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.py +++ b/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.py @@ -31,9 +31,12 @@ for k, v in b_dict.items(): class Foo: c_dict = {} + for k, v in Foo.c_dict.items(): print(b_dict[k]) # Should not emit warning, accessing other dictionary print(Foo.c_dict[k]) # [unnecessary-dict-index-lookup] + unnecessary = 0 # pylint: disable=invalid-name + unnecessary += Foo.c_dict[k] # [unnecessary-dict-index-lookup] Foo.c_dict[k] += v # key access necessary # Tests on comprehensions diff --git a/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.txt b/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.txt index e780f669f..37956ab3f 100644 --- a/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.txt +++ b/tests/functional/u/unnecessary/unnecessary_dict_index_lookup.txt @@ -7,16 +7,17 @@ unnecessary-dict-index-lookup:24:33::Unnecessary dictionary index lookup, use 'v unnecessary-dict-index-lookup:26:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH unnecessary-dict-index-lookup:27:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH unnecessary-dict-index-lookup:27:41::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:36:10::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:40:40::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:42:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:43:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:43:52::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:45:37::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:47:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:48:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:48:49::Unnecessary dictionary index lookup, use 'v' instead:HIGH -unnecessary-dict-index-lookup:54:10::Unnecessary dictionary index lookup, use 'item[1]' instead:HIGH -unnecessary-dict-index-lookup:57:1::Unnecessary dictionary index lookup, use 'item[1]' instead:HIGH -unnecessary-dict-index-lookup:62:10::Unnecessary dictionary index lookup, use 'item[1]' instead:HIGH -unnecessary-dict-index-lookup:79:14::Unnecessary dictionary index lookup, use '_' instead:HIGH +unnecessary-dict-index-lookup:37:10::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:39:19::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:43:40::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:45:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:46:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:46:52::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:48:37::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:50:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:51:1::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:51:49::Unnecessary dictionary index lookup, use 'v' instead:HIGH +unnecessary-dict-index-lookup:57:10::Unnecessary dictionary index lookup, use 'item[1]' instead:HIGH +unnecessary-dict-index-lookup:60:1::Unnecessary dictionary index lookup, use 'item[1]' instead:HIGH +unnecessary-dict-index-lookup:65:10::Unnecessary dictionary index lookup, use 'item[1]' instead:HIGH +unnecessary-dict-index-lookup:82:14::Unnecessary dictionary index lookup, use '_' instead:HIGH |