diff options
| author | Konstantin Manna <Konstantin@Manna.uno> | 2018-07-04 20:30:45 +0200 |
|---|---|---|
| committer | Bryce Guinta <bryce.guinta@protonmail.com> | 2018-07-05 23:26:50 -0600 |
| commit | 255b6be4dccef7d29678cb54b5d7ffcb45b23fe6 (patch) | |
| tree | 94c5e7ca69fcf6ffb4cc54807af8deaf3e420c15 | |
| parent | 18023f050f9db7d63df38ab0d18072b60aabee24 (diff) | |
| download | pylint-git-255b6be4dccef7d29678cb54b5d7ffcb45b23fe6.tar.gz | |
Check Slice is type index (fix #2252)
| -rw-r--r-- | pylint/checkers/refactoring.py | 1 | ||||
| -rw-r--r-- | pylint/test/functional/consider_using_get.py | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/pylint/checkers/refactoring.py b/pylint/checkers/refactoring.py index c90312bd1..53ebe6326 100644 --- a/pylint/checkers/refactoring.py +++ b/pylint/checkers/refactoring.py @@ -389,6 +389,7 @@ class RefactoringChecker(checkers.BaseTokenChecker): and isinstance(node.body[0], astroid.Assign) and isinstance(node.body[0].value, astroid.Subscript) and type_and_name_are_equal(node.body[0].value.value, node.test.ops[0][1]) + and isinstance(node.body[0].value.slice, astroid.Index) and type_and_name_are_equal(node.body[0].value.slice.value, node.test.left) and len(node.body[0].targets) == 1 and isinstance(node.body[0].targets[0], astroid.AssignName) diff --git a/pylint/test/functional/consider_using_get.py b/pylint/test/functional/consider_using_get.py index 15599634f..8c5c68901 100644 --- a/pylint/test/functional/consider_using_get.py +++ b/pylint/test/functional/consider_using_get.py @@ -85,3 +85,6 @@ d2 = {} # Cannot be represented as using .get() if 'foo' in d1: d2['bar'] = d1['foo'] + +if 'key' in dictionary: + variable = dictionary[1:] |