Simplify and improve the logic of consider-iterating-dictionary

1 files changed, 9 insertions, 4 deletions

diff --git a/pylint/checkers/refactoring.py b/pylint/checkers/refactoring.py
index 05fef1f11..18f2642f9 100644
--- a/pylint/checkers/refactoring.py
+++ b/pylint/checkers/refactoring.py
@@ -1260,12 +1260,17 @@ class RecommandationChecker(checkers.BaseChecker):
 
     @utils.check_messages("consider-iterating-dictionary")
     def visit_call(self, node):
-        inferred = utils.safe_infer(node.func)
-        if not inferred:
+        if not isinstance(node.func, astroid.Attribute):
+            return
+        if node.func.attrname != "keys":
             return
-        if not isinstance(inferred, astroid.BoundMethod):
+        if not isinstance(node.parent, (astroid.For, astroid.Comprehension)):
             return
-        if not isinstance(inferred.bound, astroid.Dict) or inferred.name != "keys":
+
+        inferred = utils.safe_infer(node.func)
+        if not isinstance(inferred, astroid.BoundMethod) or not isinstance(
+            inferred.bound, astroid.Dict
+        ):
             return
 
         if isinstance(node.parent, (astroid.For, astroid.Comprehension)):