summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEmile Anclin <emile.anclin@logilab.fr>2010-11-24 13:47:32 +0100
committerEmile Anclin <emile.anclin@logilab.fr>2010-11-24 13:47:32 +0100
commit0824e1a81e2dc8f16d5eb64ebd0218d1b36948e8 (patch)
tree4d0a5449198db83b858a37e6c59f9477b0213d2d
parentb75f6debc96c7fcfd1439264b484b4879156bd10 (diff)
downloadpylint-git-0824e1a81e2dc8f16d5eb64ebd0218d1b36948e8.tar.gz
py3k: fix W0703 warning
-rw-r--r--checkers/exceptions.py11
1 files changed, 5 insertions, 6 deletions
diff --git a/checkers/exceptions.py b/checkers/exceptions.py
index f32c65b72..0ba93f8ee 100644
--- a/checkers/exceptions.py
+++ b/checkers/exceptions.py
@@ -58,6 +58,10 @@ MSGS = {
}
+if sys.version_info < (3, 0):
+ EXCEPTIONS_MODULE = "exceptions"
+else:
+ EXCEPTIONS_MODULE = "builtins"
class ExceptionsChecker(BaseChecker):
"""checks for
@@ -160,17 +164,12 @@ class ExceptionsChecker(BaseChecker):
previous_exc.name, exc.name)
self.add_message('E0701', node=handler.type, args=msg)
if (exc.name == 'Exception'
- and exc.root().name == 'exceptions'
+ and exc.root().name == EXCEPTIONS_MODULE
and nb_handlers == 1 and not is_raising(handler.body)):
self.add_message('W0703', node=handler.type)
exceptions_classes += excs
-if sys.version_info < (3, 0):
- EXCEPTIONS_MODULE = "exceptions"
-else:
- EXCEPTIONS_MODULE = "builtins"
-
def inherit_from_std_ex(node):
"""return true if the given class node is subclass of
exceptions.Exception