summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEmile Anclin <emile.anclin@logilab.fr>2010-12-13 14:42:55 +0100
committerEmile Anclin <emile.anclin@logilab.fr>2010-12-13 14:42:55 +0100
commit7a63f9b28bade89d2c46e6e763455173ab562536 (patch)
tree91d864b8b07519cf33c41d07b49c74977c0a093a
parente0af698a87bfba6853af930c6f947969859e595a (diff)
downloadpylint-git-7a63f9b28bade89d2c46e6e763455173ab562536.tar.gz
test: fix tests, test some more message and report disabling
-rw-r--r--test/unittest_lint.py40
1 files changed, 35 insertions, 5 deletions
diff --git a/test/unittest_lint.py b/test/unittest_lint.py
index ebb2d6291..66641f12a 100644
--- a/test/unittest_lint.py
+++ b/test/unittest_lint.py
@@ -201,11 +201,11 @@ class PyLinterTC(TestCase):
pass
def test_enable_report(self):
- self.assertEqual(self.linter.is_report_enabled('RP0001'), True)
+ self.assertEqual(self.linter.report_is_enabled('RP0001'), True)
self.linter.disable('RP0001')
- self.assertEqual(self.linter.is_report_enabled('RP0001'), False)
+ self.assertEqual(self.linter.report_is_enabled('RP0001'), False)
self.linter.enable('RP0001')
- self.assertEqual(self.linter.is_report_enabled('RP0001'), True)
+ self.assertEqual(self.linter.report_is_enabled('RP0001'), True)
def test_set_option_1(self):
linter = self.linter
@@ -223,9 +223,39 @@ class PyLinterTC(TestCase):
def test_enable_checkers(self):
self.linter.disable('design')
- self.failIf('design' in [c.name for c in self.linter.needed_checkers()])
+ self.failIf('design' in [c.name for c in self.linter.prepare_checkers()])
self.linter.enable('design')
- self.failUnless('design' in [c.name for c in self.linter.needed_checkers()])
+ self.failUnless('design' in [c.name for c in self.linter.prepare_checkers()])
+
+ def test_errors_only(self):
+ linter = self.linter
+ self.linter.error_mode()
+ checkers = self.linter.prepare_checkers()
+ checker_names = tuple(c.name for c in checkers)
+ should_not = ('design', 'format', 'imports', 'logging', 'metrics',
+ 'miscellaneous', 'similarities')
+ self.failIf(any(name in checker_names for name in should_not))
+
+ def test_disable_similar(self):
+ # XXX we have to disable them both, that's no good
+ self.linter.set_option('reports', False)
+ self.linter.set_option('disable', 'R0801')
+ self.failIf('similarities' in [c.name for c in self.linter.prepare_checkers()])
+
+ def test_disable_alot(self):
+ """check that we disabled a lot of checkers"""
+ self.linter.set_option('reports', False)
+ # FIXME should it be necessary to explicitly desactivate failures ?
+ self.linter.set_option('disable', 'R,C,W')
+ checker_names = [c.name for c in self.linter.prepare_checkers()]
+ should_not = ('design', 'logging', 'metrics', 'similarities')
+ rest = [name for name in checker_names if name in should_not]
+ self.assertListEqual(rest, [])
+ self.linter.set_option('disable', 'R,C,W,F')
+ checker_names = [c.name for c in self.linter.prepare_checkers()]
+ should_not += ('format', 'imports')
+ rest = [name for name in checker_names if name in should_not]
+ self.assertListEqual(rest, [])
class ConfigTC(TestCase):