diff options
| author | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2021-09-14 09:36:01 +0200 |
|---|---|---|
| committer | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2021-09-14 09:56:58 +0200 |
| commit | bbaa7bc9200abaab5b32de8d55ae5cc6fbbbcece (patch) | |
| tree | c97bc4cb3a659efe7c49a73ba48f67b1f1091ea1 | |
| parent | cb7bba41e598aa7aa57f71f987fd92d7704f4f78 (diff) | |
| download | pylint-git-bbaa7bc9200abaab5b32de8d55ae5cc6fbbbcece.tar.gz | |
Fix false negative for use-symbolic-message
Closes #5000
| -rw-r--r-- | ChangeLog | 4 | ||||
| -rw-r--r-- | pylint/message/message_id_store.py | 2 | ||||
| -rw-r--r-- | tests/functional/u/use/use_symbolic_message_instead.py | 2 | ||||
| -rw-r--r-- | tests/functional/u/use/use_symbolic_message_instead.txt | 27 |
4 files changed, 20 insertions, 15 deletions
@@ -93,6 +93,10 @@ Release date: TBA Closes #4616 +* Non symbolic messages with the wrong capitalisation now correctly trigger ``use-symbolic-message-instead`` + + Closes #5000 + What's New in Pylint 2.10.3? ============================ diff --git a/pylint/message/message_id_store.py b/pylint/message/message_id_store.py index 84c3747fe..f0ba0c2de 100644 --- a/pylint/message/message_id_store.py +++ b/pylint/message/message_id_store.py @@ -26,7 +26,7 @@ class MessageIdStore: def get_symbol(self, msgid: str) -> str: try: - return self.__msgid_to_symbol[msgid] + return self.__msgid_to_symbol[msgid.upper()] except KeyError as e: msg = f"'{msgid}' is not stored in the message store." raise UnknownMessageError(msg) from e diff --git a/tests/functional/u/use/use_symbolic_message_instead.py b/tests/functional/u/use/use_symbolic_message_instead.py index afdd93c67..4b826d7ca 100644 --- a/tests/functional/u/use/use_symbolic_message_instead.py +++ b/tests/functional/u/use/use_symbolic_message_instead.py @@ -1,5 +1,5 @@ # pylint: disable=C0111,R0903,T1234 # [bad-option-value,use-symbolic-message-instead,use-symbolic-message-instead] -# pylint: enable=C0111 # [use-symbolic-message-instead] +# pylint: enable=c0111,w0223 # [use-symbolic-message-instead,use-symbolic-message-instead] def my_function(arg): # [missing-function-docstring] return arg or True diff --git a/tests/functional/u/use/use_symbolic_message_instead.txt b/tests/functional/u/use/use_symbolic_message_instead.txt index 09861bf06..ba4b729f6 100644 --- a/tests/functional/u/use/use_symbolic_message_instead.txt +++ b/tests/functional/u/use/use_symbolic_message_instead.txt @@ -1,13 +1,14 @@ -bad-option-value:1:0::Bad option value 'T1234' -use-symbolic-message-instead:1:0::"'C0111' is cryptic: use '# pylint: disable=missing-docstring' instead" -use-symbolic-message-instead:1:0::"'R0903' is cryptic: use '# pylint: disable=too-few-public-methods' instead" -use-symbolic-message-instead:2:0::"'C0111' is cryptic: use '# pylint: enable=missing-docstring' instead" -missing-function-docstring:4:0:my_function:Missing function or method docstring -use-symbolic-message-instead:7:0::"'C0111' is cryptic: use '# pylint: disable=missing-docstring' instead" -use-symbolic-message-instead:8:0::"'R0903' is cryptic: use '# pylint: enable=too-few-public-methods' instead" -use-symbolic-message-instead:9:0::"'R0903' is cryptic: use '# pylint: disable=too-few-public-methods' instead" -use-symbolic-message-instead:12:0::"'C0102' is cryptic: use '# pylint: disable=blacklisted-name' instead" -use-symbolic-message-instead:16:0::"'C0102' is cryptic: use '# pylint: disable=blacklisted-name' instead" -use-symbolic-message-instead:16:0::"'R1711' is cryptic: use '# pylint: disable=useless-return' instead" -missing-function-docstring:20:0:test_enabled_by_id_msg:Missing function or method docstring -use-symbolic-message-instead:20:0::"'C0111' is cryptic: use '# pylint: enable=missing-docstring' instead" +bad-option-value:1:0::Bad option value 'T1234':HIGH +use-symbolic-message-instead:1:0::"'C0111' is cryptic: use '# pylint: disable=missing-docstring' instead":HIGH +use-symbolic-message-instead:1:0::"'R0903' is cryptic: use '# pylint: disable=too-few-public-methods' instead":HIGH +use-symbolic-message-instead:2:0::"'c0111' is cryptic: use '# pylint: enable=missing-docstring' instead":HIGH +use-symbolic-message-instead:2:0::"'w0223' is cryptic: use '# pylint: enable=abstract-method' instead":HIGH +missing-function-docstring:4:0:my_function:Missing function or method docstring:HIGH +use-symbolic-message-instead:7:0::"'C0111' is cryptic: use '# pylint: disable=missing-docstring' instead":HIGH +use-symbolic-message-instead:8:0::"'R0903' is cryptic: use '# pylint: enable=too-few-public-methods' instead":HIGH +use-symbolic-message-instead:9:0::"'R0903' is cryptic: use '# pylint: disable=too-few-public-methods' instead":HIGH +use-symbolic-message-instead:12:0::"'C0102' is cryptic: use '# pylint: disable=blacklisted-name' instead":HIGH +use-symbolic-message-instead:16:0::"'C0102' is cryptic: use '# pylint: disable=blacklisted-name' instead":HIGH +use-symbolic-message-instead:16:0::"'R1711' is cryptic: use '# pylint: disable=useless-return' instead":HIGH +missing-function-docstring:20:0:test_enabled_by_id_msg:Missing function or method docstring:HIGH +use-symbolic-message-instead:20:0::"'C0111' is cryptic: use '# pylint: enable=missing-docstring' instead":HIGH |