diff options
| author | Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> | 2022-03-24 13:15:09 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-24 13:15:09 +0100 |
| commit | 7965f08e87a3232aceb75a2508ec52b7afbc9fd7 (patch) | |
| tree | a1f583af5783e2fb47f9abd50d903df11514c9ba | |
| parent | e1ad7f26415fe74585e3f65aceaf5852672d67d9 (diff) | |
| download | pylint-git-7965f08e87a3232aceb75a2508ec52b7afbc9fd7.tar.gz | |
Add bad-open-mode and unspecified-encoding documentation (#5954)
Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
| -rw-r--r-- | doc/data/messages/b/bad-open-mode/bad.py | 3 | ||||
| -rw-r--r-- | doc/data/messages/b/bad-open-mode/good.py | 3 | ||||
| -rw-r--r-- | doc/data/messages/u/unspecified-encoding/bad.py | 3 | ||||
| -rw-r--r-- | doc/data/messages/u/unspecified-encoding/good.py | 3 | ||||
| -rw-r--r-- | pylint/checkers/stdlib.py | 2 |
5 files changed, 13 insertions, 1 deletions
diff --git a/doc/data/messages/b/bad-open-mode/bad.py b/doc/data/messages/b/bad-open-mode/bad.py new file mode 100644 index 000000000..28cfb6228 --- /dev/null +++ b/doc/data/messages/b/bad-open-mode/bad.py @@ -0,0 +1,3 @@ +def foo(file_path): + with open(file_path, "rwx") as file: # [bad-open-mode] + contents = file.read() diff --git a/doc/data/messages/b/bad-open-mode/good.py b/doc/data/messages/b/bad-open-mode/good.py new file mode 100644 index 000000000..64a853b38 --- /dev/null +++ b/doc/data/messages/b/bad-open-mode/good.py @@ -0,0 +1,3 @@ +def foo(file_path): + with open(file_path, "r") as file: + contents = file.read() diff --git a/doc/data/messages/u/unspecified-encoding/bad.py b/doc/data/messages/u/unspecified-encoding/bad.py new file mode 100644 index 000000000..4645923c5 --- /dev/null +++ b/doc/data/messages/u/unspecified-encoding/bad.py @@ -0,0 +1,3 @@ +def foo(file_path): + with open(file_path) as file: # [unspecified-encoding] + contents = file.read() diff --git a/doc/data/messages/u/unspecified-encoding/good.py b/doc/data/messages/u/unspecified-encoding/good.py new file mode 100644 index 000000000..a267a3607 --- /dev/null +++ b/doc/data/messages/u/unspecified-encoding/good.py @@ -0,0 +1,3 @@ +def foo(file_path): + with open(file_path, encoding="utf-8") as file: + contents = file.read() diff --git a/pylint/checkers/stdlib.py b/pylint/checkers/stdlib.py index 007a4f978..8761c45b3 100644 --- a/pylint/checkers/stdlib.py +++ b/pylint/checkers/stdlib.py @@ -330,7 +330,7 @@ class StdlibChecker(DeprecatedMixin, BaseChecker): "bad-open-mode", "Python supports: r, w, a[, x] modes with b, +, " "and U (only with r) options. " - "See https://docs.python.org/2/library/functions.html#open", + "See https://docs.python.org/3/library/functions.html#open", ), "W1502": ( "Using datetime.time in a boolean context.", |