summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierre Sassoulas <pierre.sassoulas@gmail.com>2023-03-21 12:38:13 +0100
committerGitHub <noreply@github.com>2023-03-21 12:38:13 +0100
commitd6595750c67f9101b842291ed44bafde7b065bd8 (patch)
tree12b54e320083564f59a36cd58676dd8069a2b2f0
parent77a392d04b11eb2c438c38fc187890faefd760e3 (diff)
downloadpylint-git-d6595750c67f9101b842291ed44bafde7b065bd8.tar.gz
[deprecation] Remove 'do_exit' from the 'Run' constructor (#8472)
-rw-r--r--doc/whatsnew/fragments/8472.internal4
-rw-r--r--pylint/lint/run.py16
-rw-r--r--pylint/testutils/_run.py5
3 files changed, 6 insertions, 19 deletions
diff --git a/doc/whatsnew/fragments/8472.internal b/doc/whatsnew/fragments/8472.internal
new file mode 100644
index 000000000..6e9c3956a
--- /dev/null
+++ b/doc/whatsnew/fragments/8472.internal
@@ -0,0 +1,4 @@
+Following a deprecation period, the ``do_exit`` argument of the ``Run`` class (and of the ``_Run``
+class in testutils) were removed.
+
+Refs #8472
diff --git a/pylint/lint/run.py b/pylint/lint/run.py
index 7c2e8c0e6..961d78a53 100644
--- a/pylint/lint/run.py
+++ b/pylint/lint/run.py
@@ -9,7 +9,7 @@ import sys
import warnings
from collections.abc import Sequence
from pathlib import Path
-from typing import Any, ClassVar
+from typing import ClassVar
from pylint import config
from pylint.checkers.utils import clear_lru_caches
@@ -97,9 +97,6 @@ def _cpu_count() -> int:
return cpu_count
-UNUSED_PARAM_SENTINEL = object()
-
-
class Run:
"""Helper class to use as main for pylint with 'run(*sys.argv[1:])'."""
@@ -123,7 +120,6 @@ group are mutually exclusive.",
args: Sequence[str],
reporter: BaseReporter | None = None,
exit: bool = True, # pylint: disable=redefined-builtin
- do_exit: Any = UNUSED_PARAM_SENTINEL,
) -> None:
# Immediately exit if user asks for version
if "--version" in args:
@@ -215,16 +211,6 @@ group are mutually exclusive.",
else:
linter.check(args)
score_value = linter.generate_reports()
-
- if do_exit is not UNUSED_PARAM_SENTINEL:
- # TODO: 3.0
- warnings.warn(
- "do_exit is deprecated and it is going to be removed in a future version.",
- DeprecationWarning,
- stacklevel=2,
- )
- exit = do_exit
-
if linter.config.clear_cache_post_run:
clear_lru_caches()
MANAGER.clear_cache()
diff --git a/pylint/testutils/_run.py b/pylint/testutils/_run.py
index 0ad68868f..f1e7fbb9a 100644
--- a/pylint/testutils/_run.py
+++ b/pylint/testutils/_run.py
@@ -10,10 +10,8 @@ This module is considered private and can change at any time.
from __future__ import annotations
from collections.abc import Sequence
-from typing import Any
from pylint.lint import Run as LintRun
-from pylint.lint.run import UNUSED_PARAM_SENTINEL
from pylint.reporters.base_reporter import BaseReporter
from pylint.testutils.lint_module_test import PYLINTRC
@@ -39,7 +37,6 @@ class _Run(LintRun):
args: Sequence[str],
reporter: BaseReporter | None = None,
exit: bool = True, # pylint: disable=redefined-builtin
- do_exit: Any = UNUSED_PARAM_SENTINEL,
) -> None:
args = _add_rcfile_default_pylintrc(list(args))
- super().__init__(args, reporter, exit, do_exit)
+ super().__init__(args, reporter, exit)