summaryrefslogtreecommitdiff
path: root/pylint/checkers/refactoring/recommendation_checker.py
diff options
context:
space:
mode:
authorYu Shao, Pang <p.yushao2@gmail.com>2021-07-07 20:47:45 +0800
committerYu Shao, Pang <p.yushao2@gmail.com>2021-07-07 20:47:45 +0800
commit9706392790eb6c6d7166d2521dfdf8ed69cf055c (patch)
tree5ca6249209e775d3ada07518519aa47ad2718855 /pylint/checkers/refactoring/recommendation_checker.py
parentaa6868f1919dca34cb78f88da9de681b45b04cf7 (diff)
downloadpylint-git-9706392790eb6c6d7166d2521dfdf8ed69cf055c.tar.gz
Update code from review feedback
Diffstat (limited to 'pylint/checkers/refactoring/recommendation_checker.py')
-rw-r--r--pylint/checkers/refactoring/recommendation_checker.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/pylint/checkers/refactoring/recommendation_checker.py b/pylint/checkers/refactoring/recommendation_checker.py
index 6445b2da2..0cb724985 100644
--- a/pylint/checkers/refactoring/recommendation_checker.py
+++ b/pylint/checkers/refactoring/recommendation_checker.py
@@ -108,14 +108,17 @@ class RecommendationChecker(checkers.BaseChecker):
# Check if loop present within the scope of the node
scope = node.scope()
for loop_node in scope.nodes_of_class((astroid.For, astroid.While)):
+ loop_node = cast(astroid.node_classes.NodeNG, loop_node)
if not loop_node.parent_of(node):
continue
# Check if var is mutated within loop (Assign/AugAssign)
for assignment_node in loop_node.nodes_of_class(astroid.AugAssign):
+ assignment_node = cast(astroid.AugAssign, assignment_node)
if node.parent.slice.name == assignment_node.target.name:
return
for assignment_node in loop_node.nodes_of_class(astroid.Assign):
+ assignment_node = cast(astroid.Assign, assignment_node)
if node.parent.slice.name in [
n.name for n in assignment_node.targets
]: