diff options
author | Or <or.ba402@gmail.com> | 2020-10-02 18:19:31 +0300 |
---|---|---|
committer | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2020-10-07 21:22:04 +0200 |
commit | 83bc7593ac77e400bc42babbbc510c3d7fe7cc15 (patch) | |
tree | 630d543cf61352c1eea2b364411b55c19ca83dfb /pylint/extensions/empty_comment.py | |
parent | 98d2c060ba0dbae6abecff2393cb6dd8a9bde97b (diff) | |
download | pylint-git-83bc7593ac77e400bc42babbbc510c3d7fe7cc15.tar.gz |
Add empty-comment checker extension
PR Review:
refactor checker messages, test cases added: empty commit case, comments row case. unittest - pathlib replaces os.path.
python3.5 fix for pathlib library use
refactor `comment_ending` to `empty_comment`
empty-comment test fixed (after Rebase)
Diffstat (limited to 'pylint/extensions/empty_comment.py')
-rw-r--r-- | pylint/extensions/empty_comment.py | 56 |
1 files changed, 56 insertions, 0 deletions
diff --git a/pylint/extensions/empty_comment.py b/pylint/extensions/empty_comment.py new file mode 100644 index 000000000..2ab7da9a1 --- /dev/null +++ b/pylint/extensions/empty_comment.py @@ -0,0 +1,56 @@ +from pylint.checkers import BaseChecker +from pylint.interfaces import IRawChecker + + +def is_line_commented(line): + """ Checks if a `# symbol that is not part of a string was found in line""" + + comment_idx = line.find(b"#") + if comment_idx == -1: + return False + if comment_part_of_string(line, comment_idx): + return is_line_commented(line[:comment_idx] + line[comment_idx + 1 :]) + return True + + +def comment_part_of_string(line, comment_idx): + """ checks if the symbol at comment_idx is part of a string """ + + if ( + line[:comment_idx].count(b"'") % 2 == 1 + and line[comment_idx:].count(b"'") % 2 == 1 + ) or ( + line[:comment_idx].count(b'"') % 2 == 1 + and line[comment_idx:].count(b'"') % 2 == 1 + ): + return True + return False + + +class CommentChecker(BaseChecker): + __implements__ = IRawChecker + + name = "refactoring" + msgs = { + "R2044": ( + "Line with empty comment", + "empty-comment", + ( + "Used when a # symbol appears on a line not followed by an actual comment" + ), + ) + } + options = () + priority = -1 # low priority + + def process_module(self, node): + with node.stream() as stream: + for (line_num, line) in enumerate(stream): + line = line.rstrip() + if line.endswith(b"#"): + if not is_line_commented(line[:-1]): + self.add_message("empty-comment", line=line_num) + + +def register(linter): + linter.register_checker(CommentChecker(linter)) |