diff options
author | Daniƫl van Noord <13665637+DanielNoord@users.noreply.github.com> | 2022-04-19 17:38:15 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-19 17:38:15 +0200 |
commit | 5ee5cf77cd1c6f9bf83cfcc696f42dad204e9735 (patch) | |
tree | 8ec55209e9096794ec53d7ffc6a3c5660ec0bc9a /pylint/lint/parallel.py | |
parent | c550cce659a4341923cf28cdb167ae89d1c85a74 (diff) | |
download | pylint-git-5ee5cf77cd1c6f9bf83cfcc696f42dad204e9735.tar.gz |
Deprecate ``MapReduceMixin`` and implements its methods in ``BaseChecker`` (#6383)
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Diffstat (limited to 'pylint/lint/parallel.py')
-rw-r--r-- | pylint/lint/parallel.py | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/pylint/lint/parallel.py b/pylint/lint/parallel.py index 34dc2a918..60610b02e 100644 --- a/pylint/lint/parallel.py +++ b/pylint/lint/parallel.py @@ -71,11 +71,9 @@ def _worker_check_single_file( _worker_linter.check_single_file_item(file_item) mapreduce_data = defaultdict(list) for checker in _worker_linter.get_checkers(): - try: - data = checker.get_map_data() # type: ignore[attr-defined] - except AttributeError: - continue - mapreduce_data[checker.name].append(data) + data = checker.get_map_data() + if data is not None: + mapreduce_data[checker.name].append(data) msgs = _worker_linter.reporter.messages assert isinstance(_worker_linter.reporter, reporters.CollectingReporter) _worker_linter.reporter.reset() @@ -108,7 +106,7 @@ def _merge_mapreduce_data( # validation. The intent here is to collect all the mapreduce data for all checker- # runs across processes - that will then be passed to a static method on the # checkers to be reduced and further processed. - collated_map_reduce_data = defaultdict(list) + collated_map_reduce_data: defaultdict[str, list[Any]] = defaultdict(list) for linter_data in all_mapreduce_data.values(): for run_data in linter_data: for checker_name, data in run_data.items(): @@ -120,7 +118,7 @@ def _merge_mapreduce_data( if checker.name in collated_map_reduce_data: # Assume that if the check has returned map/reduce data that it has the # reducer function - checker.reduce_map_data(linter, collated_map_reduce_data[checker.name]) # type: ignore[attr-defined] + checker.reduce_map_data(linter, collated_map_reduce_data[checker.name]) def check_parallel( @@ -132,8 +130,7 @@ def check_parallel( """Use the given linter to lint the files with given amount of workers (jobs). This splits the work filestream-by-filestream. If you need to do work across - multiple files, as in the similarity-checker, then inherit from MapReduceMixin and - implement the map/reduce mixin functionality. + multiple files, as in the similarity-checker, then implement the map/reduce mixin functionality. """ # The linter is inherited by all the pool's workers, i.e. the linter # is identical to the linter object here. This is required so that |