summaryrefslogtreecommitdiff
path: root/pylint/test/functional
diff options
context:
space:
mode:
authorClaudiu Popa <pcmanticore@gmail.com>2018-09-05 10:16:37 +0200
committerClaudiu Popa <pcmanticore@gmail.com>2018-09-05 10:16:37 +0200
commit1dab9872046bb36d013d3e6008e6e70bc07988a4 (patch)
tree8e566d879e2f35351eea2383eb80a1a5c7c13d80 /pylint/test/functional
parent0c6d58fe2bfdde184d1d24536dc0ce69c0cd49d3 (diff)
downloadpylint-git-1dab9872046bb36d013d3e6008e6e70bc07988a4.tar.gz
Add a new check, ``duplicate-string-formatting-argument``
This new check is emitted whenever a duplicate string formatting argument is found. Close #497
Diffstat (limited to 'pylint/test/functional')
-rw-r--r--pylint/test/functional/duplicate_string_formatting_argument.py15
-rw-r--r--pylint/test/functional/duplicate_string_formatting_argument.txt2
2 files changed, 17 insertions, 0 deletions
diff --git a/pylint/test/functional/duplicate_string_formatting_argument.py b/pylint/test/functional/duplicate_string_formatting_argument.py
new file mode 100644
index 000000000..b012f98e0
--- /dev/null
+++ b/pylint/test/functional/duplicate_string_formatting_argument.py
@@ -0,0 +1,15 @@
+# pylint: disable=missing-docstring
+
+NAME = 42
+OTHER_NAME = 24
+OTHER_OTHER_NAME = 2
+
+# +1: [duplicate-string-formatting-argument,duplicate-string-formatting-argument]
+CONST = "some value {} some other value {} {} {} {} {}".format(
+ NAME,
+ NAME,
+ OTHER_NAME,
+ OTHER_NAME,
+ OTHER_NAME,
+ OTHER_OTHER_NAME,
+)
diff --git a/pylint/test/functional/duplicate_string_formatting_argument.txt b/pylint/test/functional/duplicate_string_formatting_argument.txt
new file mode 100644
index 000000000..6d352eb2e
--- /dev/null
+++ b/pylint/test/functional/duplicate_string_formatting_argument.txt
@@ -0,0 +1,2 @@
+duplicate-string-formatting-argument:8::Duplicate string formatting argument 'NAME', consider passing as named argument
+duplicate-string-formatting-argument:8::Duplicate string formatting argument 'OTHER_NAME', consider passing as named argument