diff options
| author | Sushobhit <31987769+sushobhit27@users.noreply.github.com> | 2018-08-31 13:40:08 +0530 |
|---|---|---|
| committer | Claudiu Popa <pcmanticore@gmail.com> | 2018-08-31 10:10:08 +0200 |
| commit | e3cb6d4a99162497f9a809eb721f7964f4c536ac (patch) | |
| tree | 68a641a6717883b61d8b9ae58151fa014f95cf41 /pylint/test/functional | |
| parent | 66cb32187c040f82dd067bc0d226b2f105bf6c38 (diff) | |
| download | pylint-git-e3cb6d4a99162497f9a809eb721f7964f4c536ac.tar.gz | |
Emit unused-import instead of unused-variable when dealing with unused imports
When pylint encounters unused imports in scopes (e.g. functions),
it used to emit `unused-variable`. This is somewhat confusing, as those
names are not necessarily variables, so instead let's emit the more
obvious `unused-import`.
Close #2421
Diffstat (limited to 'pylint/test/functional')
| -rw-r--r-- | pylint/test/functional/unused_variable.py | 11 | ||||
| -rw-r--r-- | pylint/test/functional/unused_variable.txt | 8 |
2 files changed, 13 insertions, 6 deletions
diff --git a/pylint/test/functional/unused_variable.py b/pylint/test/functional/unused_variable.py index 24d7b3ded..4e6d58fe4 100644 --- a/pylint/test/functional/unused_variable.py +++ b/pylint/test/functional/unused_variable.py @@ -1,11 +1,11 @@ # pylint: disable=missing-docstring, invalid-name, too-few-public-methods, no-self-use, useless-object-inheritance def test_regression_737(): - import xml # [unused-variable] + import xml # [unused-import] def test_regression_923(): - import unittest.case # [unused-variable] - import xml as sql # [unused-variable] + import unittest.case # [unused-import] + import xml as sql # [unused-import] def test_unused_with_prepended_underscore(): _foo = 42 @@ -48,3 +48,8 @@ def locals_does_not_account_for_subscopes(): def some_other_scope(): return locals() return some_other_scope + + +def unused_import_from(): + from functools import wraps as abc # [unused-import] + from collections import namedtuple # [unused-import] diff --git a/pylint/test/functional/unused_variable.txt b/pylint/test/functional/unused_variable.txt index ff4eb211a..231528be3 100644 --- a/pylint/test/functional/unused_variable.txt +++ b/pylint/test/functional/unused_variable.txt @@ -1,6 +1,6 @@ -unused-variable:4:test_regression_737:Unused variable 'xml' -unused-variable:7:test_regression_923:Unused variable 'unittest.case' -unused-variable:8:test_regression_923:Unused variable 'sql' +unused-import:4:test_regression_737:Unused import xml +unused-import:7:test_regression_923:Unused import unittest.case +unused-import:8:test_regression_923:Unused xml imported as sql unused-variable:15:test_unused_with_prepended_underscore:Unused variable '_a_' unused-variable:16:test_unused_with_prepended_underscore:Unused variable '__a__' unused-variable:20:test_local_field_prefixed_with_unused_or_ignored:Unused variable 'flagged_local_field' @@ -8,3 +8,5 @@ unused-variable:28:HasUnusedDunderClass.test:Unused variable '__class__' possibly-unused-variable:35:locals_example_defined_before:Possibly unused variable 'value' unused-variable:41:locals_example_defined_after:Unused variable 'value' unused-variable:46:locals_does_not_account_for_subscopes:Unused variable 'value' +unused-import:54:unused_import_from:Unused wraps imported from functools as abc +unused-import:55:unused_import_from:Unused namedtuple imported from collections |