Create subdirectory for crowded functional tests

24 files changed, 797 insertions, 0 deletions

diff --git a/tests/functional/n/no/__init__.py b/tests/functional/n/no/__init__.py
new file mode 100644
index 000000000..e69de29bb
--- /dev/null
+++ b/tests/functional/n/no/__init__.py
diff --git a/tests/functional/n/no/no_classmethod_decorator.py b/tests/functional/n/no/no_classmethod_decorator.py
new file mode 100644
index 000000000..66cc0b3c0
--- /dev/null
+++ b/tests/functional/n/no/no_classmethod_decorator.py
@@ -0,0 +1,35 @@
+"""Checks class methods are declared with a decorator if within the class
+scope and if classmethod's argument is a member of the class
+"""
+
+# pylint: disable=too-few-public-methods, using-constant-test, no-self-argument, useless-object-inheritance
+
+class MyClass(object):
+    """Some class"""
+    def __init__(self):
+        pass
+
+    def cmethod(cls):
+        """class method-to-be"""
+    cmethod = classmethod(cmethod)  # [no-classmethod-decorator]
+
+    if True:
+        cmethod = classmethod(cmethod)  # [no-classmethod-decorator]
+
+    @classmethod
+    def my_second_method(cls):
+        """correct class method definition"""
+
+    def other_method(cls):
+        """some method"""
+    cmethod2 = classmethod(other_method)  # [no-classmethod-decorator]
+
+def helloworld():
+    """says hello"""
+
+
+MyClass.new_class_method = classmethod(helloworld)
+
+class MyOtherClass(object):
+    """Some other class"""
+    _make = classmethod(tuple.__new__)
diff --git a/tests/functional/n/no/no_classmethod_decorator.txt b/tests/functional/n/no/no_classmethod_decorator.txt
new file mode 100644
index 000000000..90b10f2b1
--- /dev/null
+++ b/tests/functional/n/no/no_classmethod_decorator.txt
@@ -0,0 +1,3 @@
+no-classmethod-decorator:14:4:MyClass:Consider using a decorator instead of calling classmethod
+no-classmethod-decorator:17:8:MyClass:Consider using a decorator instead of calling classmethod
+no-classmethod-decorator:25:4:MyClass:Consider using a decorator instead of calling classmethod
diff --git a/tests/functional/n/no/no_else_break.py b/tests/functional/n/no/no_else_break.py
new file mode 100644
index 000000000..cf23f313a
--- /dev/null
+++ b/tests/functional/n/no/no_else_break.py
@@ -0,0 +1,137 @@
+""" Test that superfluous else return are detected. """
+
+# pylint:disable=invalid-name,missing-docstring,unused-variable
+
+
+def foo1(x, y, z):
+    for i in x:
+        if i > y:  # [no-else-break]
+            break
+        else:
+            a = z
+
+
+def foo2(x, y, w, z):
+    for i in x:
+        if i > y:  # [no-else-break]
+            break
+        elif i > w:
+            break
+        else:
+            a = z
+
+
+def foo3(x, y, z):
+    for i in x:
+        if i > y:
+            a = 1
+            if z:  # [no-else-break]
+                b = 2
+                break
+            else:
+                c = 3
+                break
+        else:
+            d = 4
+            break
+
+
+def foo4(x, y):
+    for i in x:
+        if i > x:  # [no-else-break]
+            if y:
+                a = 4
+            else:
+                b = 2
+            break
+        else:
+            c = 3
+        break
+
+
+def foo5(x, y, z):
+    for i in x:
+        if i > y:  # [no-else-break]
+            if y:
+                a = 4
+            else:
+                b = 2
+            break
+        elif z:
+            c = 2
+        else:
+            c = 3
+        break
+
+
+def foo6(x, y):
+    for i in x:
+        if i > x:
+            if y:  # [no-else-break]
+                a = 4
+                break
+            else:
+                b = 2
+        else:
+            c = 3
+        break
+
+
+def bar1(x, y, z):
+    for i in x:
+        if i > y:
+            break
+        return z
+
+
+def bar2(w, x, y, z):
+    for i in w:
+        if i > x:
+            break
+        if z < i:
+            a = y
+        else:
+            break
+        return
+
+
+def bar3(x, y, z):
+    for i in x:
+        if i > y:
+            if z:
+                break
+        else:
+            return z
+        return None
+
+
+def bar4(x):
+    for i in range(10):
+        if x:  # [no-else-break]
+            break
+        else:
+            try:
+                return
+            except ValueError:
+                break
+
+
+def nested1(x, y, z):
+    for i in x:
+        if i > x:
+            for j in y:
+                if j < z:
+                    break
+        else:
+            a = z
+
+
+def nested2(x, y, z):
+    for i in x:
+        if i > x:
+            for j in y:
+                if j > z:
+                    break
+                break
+        else:
+            a = z
diff --git a/tests/functional/n/no/no_else_break.txt b/tests/functional/n/no/no_else_break.txt
new file mode 100644
index 000000000..d1a27f73c
--- /dev/null
+++ b/tests/functional/n/no/no_else_break.txt
@@ -0,0 +1,7 @@
+no-else-break:8:8:foo1:"Unnecessary ""else"" after ""break"""
+no-else-break:16:8:foo2:"Unnecessary ""elif"" after ""break"""
+no-else-break:28:12:foo3:"Unnecessary ""else"" after ""break"""
+no-else-break:41:8:foo4:"Unnecessary ""else"" after ""break"""
+no-else-break:54:8:foo5:"Unnecessary ""elif"" after ""break"""
+no-else-break:70:12:foo6:"Unnecessary ""else"" after ""break"""
+no-else-break:110:8:bar4:"Unnecessary ""else"" after ""break"""
diff --git a/tests/functional/n/no/no_else_continue.py b/tests/functional/n/no/no_else_continue.py
new file mode 100644
index 000000000..37f70f121
--- /dev/null
+++ b/tests/functional/n/no/no_else_continue.py
@@ -0,0 +1,137 @@
+""" Test that superfluous else return are detected. """
+
+# pylint:disable=invalid-name,missing-docstring,unused-variable
+
+
+def foo1(x, y, z):
+    for i in x:
+        if i < y:  # [no-else-continue]
+            continue
+        else:
+            a = z
+
+
+def foo2(x, y, w, z):
+    for i in x:
+        if i < y:  # [no-else-continue]
+            continue
+        elif i < w:
+            continue
+        else:
+            a = z
+
+
+def foo3(x, y, z):
+    for i in x:
+        if i < y:
+            a = 1
+            if z:  # [no-else-continue]
+                b = 2
+                continue
+            else:
+                c = 3
+                continue
+        else:
+            d = 4
+            continue
+
+
+def foo4(x, y):
+    for i in x:
+        if i < x:  # [no-else-continue]
+            if y:
+                a = 4
+            else:
+                b = 2
+            continue
+        else:
+            c = 3
+        continue
+
+
+def foo5(x, y, z):
+    for i in x:
+        if i < y:  # [no-else-continue]
+            if y:
+                a = 4
+            else:
+                b = 2
+            continue
+        elif z:
+            c = 2
+        else:
+            c = 3
+        continue
+
+
+def foo6(x, y):
+    for i in x:
+        if i < x:
+            if y:  # [no-else-continue]
+                a = 4
+                continue
+            else:
+                b = 2
+        else:
+            c = 3
+        continue
+
+
+def bar1(x, y, z):
+    for i in x:
+        if i < y:
+            continue
+        return z
+
+
+def bar2(w, x, y, z):
+    for i in w:
+        if i < x:
+            continue
+        if z < i:
+            a = y
+        else:
+            continue
+        return
+
+
+def bar3(x, y, z):
+    for i in x:
+        if i < y:
+            if z:
+                continue
+        else:
+            return z
+        return None
+
+
+def bar4(x):
+    for i in range(10):
+        if x:  # [no-else-continue]
+            continue
+        else:
+            try:
+                return
+            except ValueError:
+                continue
+
+
+def nested1(x, y, z):
+    for i in x:
+        if i < x:
+            for j in y:
+                if j < z:
+                    continue
+        else:
+            a = z
+
+
+def nested2(x, y, z):
+    for i in x:
+        if i < x:
+            for j in y:
+                if j < z:
+                    continue
+                continue
+        else:
+            a = z
diff --git a/tests/functional/n/no/no_else_continue.txt b/tests/functional/n/no/no_else_continue.txt
new file mode 100644
index 000000000..6d659ea28
--- /dev/null
+++ b/tests/functional/n/no/no_else_continue.txt
@@ -0,0 +1,7 @@
+no-else-continue:8:8:foo1:"Unnecessary ""else"" after ""continue"""
+no-else-continue:16:8:foo2:"Unnecessary ""elif"" after ""continue"""
+no-else-continue:28:12:foo3:"Unnecessary ""else"" after ""continue"""
+no-else-continue:41:8:foo4:"Unnecessary ""else"" after ""continue"""
+no-else-continue:54:8:foo5:"Unnecessary ""elif"" after ""continue"""
+no-else-continue:70:12:foo6:"Unnecessary ""else"" after ""continue"""
+no-else-continue:110:8:bar4:"Unnecessary ""else"" after ""continue"""
diff --git a/tests/functional/n/no/no_else_raise.py b/tests/functional/n/no/no_else_raise.py
new file mode 100644
index 000000000..ae807fae3
--- /dev/null
+++ b/tests/functional/n/no/no_else_raise.py
@@ -0,0 +1,110 @@
+""" Test that superfluous else return are detected. """
+
+# pylint:disable=invalid-name,missing-docstring,unused-variable,raise-missing-from
+
+def foo1(x, y, z):
+    if x:  # [no-else-raise]
+        a = 1
+        raise Exception(y)
+    else:
+        b = 2
+        raise Exception(z)
+
+
+def foo2(x, y, w, z):
+    if x:  # [no-else-raise]
+        a = 1
+        raise Exception(y)
+    elif z:
+        b = 2
+        raise Exception(w)
+    else:
+        c = 3
+        raise Exception(z)
+
+
+def foo3(x, y, z):
+    if x:
+        a = 1
+        if y:  # [no-else-raise]
+            b = 2
+            raise Exception(y)
+        else:
+            c = 3
+            raise Exception(x)
+    else:
+        d = 4
+        raise Exception(z)
+
+
+def foo4(x, y):
+    if x: # [no-else-raise]
+        if y:
+            a = 4
+        else:
+            b = 2
+        raise Exception(x)
+    else:
+        c = 3
+    raise Exception(y)
+
+
+def foo5(x, y, z):
+    if x: # [no-else-raise]
+        if y:
+            a = 4
+        else:
+            b = 2
+        raise Exception(x)
+    elif z:
+        raise Exception(y)
+    else:
+        c = 3
+    raise Exception(z)
+
+
+def foo6(x, y):
+    if x:
+        if y:   # [no-else-raise]
+            a = 4
+            raise Exception(x)
+        else:
+            b = 2
+    else:
+        c = 3
+    raise Exception(y)
+
+
+def bar1(x, y, z):
+    if x:
+        raise Exception(y)
+    raise Exception(z)
+
+
+def bar2(w, x, y, z):
+    if x:
+        raise Exception(y)
+    if z:
+        a = 1
+    else:
+        raise Exception(w)
+    raise Exception(None)
+
+
+def bar3(x, y, z):
+    if x:
+        if z:
+            raise Exception(y)
+    else:
+        raise Exception(z)
+    raise Exception(None)
+
+
+def bar4(x):
+    if x:  # [no-else-raise]
+        raise Exception(True)
+    else:
+        try:
+            raise Exception(False)
+        except ValueError:
+            raise Exception(None)
diff --git a/tests/functional/n/no/no_else_raise.txt b/tests/functional/n/no/no_else_raise.txt
new file mode 100644
index 000000000..b41f7132f
--- /dev/null
+++ b/tests/functional/n/no/no_else_raise.txt
@@ -0,0 +1,7 @@
+no-else-raise:6:4:foo1:"Unnecessary ""else"" after ""raise"""
+no-else-raise:15:4:foo2:"Unnecessary ""elif"" after ""raise"""
+no-else-raise:29:8:foo3:"Unnecessary ""else"" after ""raise"""
+no-else-raise:41:4:foo4:"Unnecessary ""else"" after ""raise"""
+no-else-raise:53:4:foo5:"Unnecessary ""elif"" after ""raise"""
+no-else-raise:68:8:foo6:"Unnecessary ""else"" after ""raise"""
+no-else-raise:104:4:bar4:"Unnecessary ""else"" after ""raise"""
diff --git a/tests/functional/n/no/no_else_return.py b/tests/functional/n/no/no_else_return.py
new file mode 100644
index 000000000..0a87551fa
--- /dev/null
+++ b/tests/functional/n/no/no_else_return.py
@@ -0,0 +1,110 @@
+""" Test that superfluous else return are detected. """
+
+
+# pylint:disable=invalid-name,missing-docstring,unused-variable
+def foo1(x, y, z):
+    if x:  # [no-else-return]
+        a = 1
+        return y
+    else:
+        b = 2
+        return z
+
+
+def foo2(x, y, w, z):
+    if x:  # [no-else-return]
+        a = 1
+        return y
+    elif z:
+        b = 2
+        return w
+    else:
+        c = 3
+        return z
+
+
+def foo3(x, y, z):
+    if x:
+        a = 1
+        if y:  # [no-else-return]
+            b = 2
+            return y
+        else:
+            c = 3
+            return x
+    else:
+        d = 4
+        return z
+
+
+def foo4(x, y):
+    if x:   # [no-else-return]
+        if y:
+            a = 4
+        else:
+            b = 2
+        return
+    else:
+        c = 3
+    return
+
+
+def foo5(x, y, z):
+    if x:   # [no-else-return]
+        if y:
+            a = 4
+        else:
+            b = 2
+        return
+    elif z:
+        c = 2
+    else:
+        c = 3
+    return
+
+
+def foo6(x, y):
+    if x:
+        if y:   # [no-else-return]
+            a = 4
+            return
+        else:
+            b = 2
+    else:
+        c = 3
+    return
+
+
+def bar1(x, y, z):
+    if x:
+        return y
+    return z
+
+
+def bar2(w, x, y, z):
+    if x:
+        return y
+    if z:
+        a = 1
+    else:
+        return w
+    return None
+
+
+def bar3(x, y, z):
+    if x:
+        if z:
+            return y
+    else:
+        return z
+    return None
+
+
+def bar4(x):
+    if x:  # [no-else-return]
+        return True
+    else:
+        try:
+            return False
+        except ValueError:
+            return None
diff --git a/tests/functional/n/no/no_else_return.txt b/tests/functional/n/no/no_else_return.txt
new file mode 100644
index 000000000..4560f7490
--- /dev/null
+++ b/tests/functional/n/no/no_else_return.txt
@@ -0,0 +1,7 @@
+no-else-return:6:4:foo1:"Unnecessary ""else"" after ""return"""
+no-else-return:15:4:foo2:"Unnecessary ""elif"" after ""return"""
+no-else-return:29:8:foo3:"Unnecessary ""else"" after ""return"""
+no-else-return:41:4:foo4:"Unnecessary ""else"" after ""return"""
+no-else-return:53:4:foo5:"Unnecessary ""elif"" after ""return"""
+no-else-return:68:8:foo6:"Unnecessary ""else"" after ""return"""
+no-else-return:104:4:bar4:"Unnecessary ""else"" after ""return"""
diff --git a/tests/functional/n/no/no_method_argument_py38.py b/tests/functional/n/no/no_method_argument_py38.py
new file mode 100644
index 000000000..c67453288
--- /dev/null
+++ b/tests/functional/n/no/no_method_argument_py38.py
@@ -0,0 +1,6 @@
+# pylint: disable=missing-docstring,too-few-public-methods
+
+
+class Cls:
+    def __init__(self, obj, /):
+        self.obj = obj
diff --git a/tests/functional/n/no/no_method_argument_py38.rc b/tests/functional/n/no/no_method_argument_py38.rc
new file mode 100644
index 000000000..85fc502b3
--- /dev/null
+++ b/tests/functional/n/no/no_method_argument_py38.rc
@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver=3.8
diff --git a/tests/functional/n/no/no_name_in_module.py b/tests/functional/n/no/no_name_in_module.py
new file mode 100644
index 000000000..73ad2db93
--- /dev/null
+++ b/tests/functional/n/no/no_name_in_module.py
@@ -0,0 +1,66 @@
+#pylint: disable=W0401,W0611,no-absolute-import,invalid-name,import-error,bare-except,broad-except,wrong-import-order,ungrouped-imports,wrong-import-position
+"""check unexistant names imported are reported"""
+from __future__ import print_function
+
+import collections.tutu  # [no-name-in-module]
+from collections import toto  # [no-name-in-module]
+toto.yo()
+
+from xml.etree import ElementTree
+ElementTree.nonexistant_function()  # [no-member]
+ElementTree.another.nonexistant.function()  # [no-member]
+
+
+import sys
+print(sys.stdout, 'hello world')
+print(sys.stdoout, 'bye bye world')  # [no-member]
+
+
+import re
+re.finditer('*', 'yo')
+
+from rie import *
+from re import findiiter, compiile  # [no-name-in-module,no-name-in-module]
+
+import os
+'SOMEVAR' in os.environ  # [pointless-statement]
+
+try:
+    from collections import something
+except ImportError:
+    something = None
+
+try:
+    from collections import anything # [no-name-in-module]
+except ValueError:
+    anything = None
+
+try:
+    import collections.missing
+except ImportError:
+    pass
+
+try:
+    import collections.indeed_missing # [no-name-in-module]
+except ValueError:
+    pass
+
+try:
+    import collections.emit # [no-name-in-module]
+except Exception:
+    pass
+
+try:
+    import collections.emit1
+except ImportError:
+    pass
+
+try:
+    if something:
+        import collections.emit2 # [no-name-in-module]
+except Exception:
+    pass
+
+from .no_self_use import Super
+from .no_self_use import lala  # [no-name-in-module]
+from .no_self_use.bla import lala1 # [no-name-in-module]
diff --git a/tests/functional/n/no/no_name_in_module.txt b/tests/functional/n/no/no_name_in_module.txt
new file mode 100644
index 000000000..883e6b5d7
--- /dev/null
+++ b/tests/functional/n/no/no_name_in_module.txt
@@ -0,0 +1,14 @@
+no-name-in-module:5:0::No name 'tutu' in module 'collections'
+no-name-in-module:6:0::No name 'toto' in module 'collections'
+no-member:10:0::Module 'xml.etree.ElementTree' has no 'nonexistant_function' member:INFERENCE
+no-member:11:0::Module 'xml.etree.ElementTree' has no 'another' member:INFERENCE
+no-member:16:6::Module 'sys' has no 'stdoout' member; maybe 'stdout'?:INFERENCE
+no-name-in-module:23:0::No name 'compiile' in module 're'
+no-name-in-module:23:0::No name 'findiiter' in module 're'
+pointless-statement:26:0::Statement seems to have no effect
+no-name-in-module:34:4::No name 'anything' in module 'collections'
+no-name-in-module:44:4::No name 'indeed_missing' in module 'collections'
+no-name-in-module:49:4::No name 'emit' in module 'collections'
+no-name-in-module:60:8::No name 'emit2' in module 'collections'
+no-name-in-module:65:0::No name 'lala' in module 'functional.n.no.no_self_use'
+no-name-in-module:66:0::No name 'bla' in module 'functional.n.no.no_self_use'
diff --git a/tests/functional/n/no/no_self_argument_py37.py b/tests/functional/n/no/no_self_argument_py37.py
new file mode 100644
index 000000000..8e6d6fc34
--- /dev/null
+++ b/tests/functional/n/no/no_self_argument_py37.py
@@ -0,0 +1,15 @@
+"""Test detection of self as argument of first method in Python 3.7 and above."""
+
+# pylint: disable=missing-docstring,too-few-public-methods,useless-object-inheritance
+
+
+class Toto(object):
+
+    def __class_getitem__(cls, params):
+        # This is actually a special method which is always a class method.
+        # See https://www.python.org/dev/peps/pep-0560/#class-getitem
+        pass
+
+    def __class_other__(cls, params):  # [no-self-argument]
+        # This is not a special case and as such is an instance method.
+        pass
diff --git a/tests/functional/n/no/no_self_argument_py37.rc b/tests/functional/n/no/no_self_argument_py37.rc
new file mode 100644
index 000000000..a17bb22da
--- /dev/null
+++ b/tests/functional/n/no/no_self_argument_py37.rc
@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver=3.7
diff --git a/tests/functional/n/no/no_self_argument_py37.txt b/tests/functional/n/no/no_self_argument_py37.txt
new file mode 100644
index 000000000..d0aba8476
--- /dev/null
+++ b/tests/functional/n/no/no_self_argument_py37.txt
@@ -0,0 +1 @@
+no-self-argument:13:4:Toto.__class_other__:"Method should have ""self"" as first argument"
diff --git a/tests/functional/n/no/no_self_use.py b/tests/functional/n/no/no_self_use.py
new file mode 100644
index 000000000..3d3cda1f2
--- /dev/null
+++ b/tests/functional/n/no/no_self_use.py
@@ -0,0 +1,78 @@
+# pylint: disable=R0903,W0232,missing-docstring, useless-object-inheritance
+"""test detection of method which could be a function"""
+
+from __future__ import print_function
+
+class Toto(object):
+    """bla bal abl"""
+
+    def __init__(self):
+        self.aaa = 2
+
+    def regular_method(self):
+        """this method is a real method since it access to self"""
+        self.function_method()
+
+    def function_method(self): # [no-self-use]
+        """this method isn' a real method since it doesn't need self"""
+        print('hello')
+
+
+class Base(object):
+    """an abstract class"""
+
+    def __init__(self):
+        self.aaa = 2
+
+    def check(self, arg):
+        """an abstract method, could not be a function"""
+        raise NotImplementedError
+
+
+class Sub(Base):
+    """a concrete class"""
+
+    def check(self, arg):
+        """a concrete method, could not be a function since it need
+        polymorphism benefits
+        """
+        return arg == 0
+
+class Super(object):
+    """same as before without abstract"""
+    attr = 1
+    def method(self):
+        """regular"""
+        print(self.attr)
+
+class Sub1(Super):
+    """override method with need for self"""
+    def method(self):
+        """no i can not be a function"""
+        print(42)
+
+    def __len__(self):
+        """no i can not be a function"""
+        print(42)
+
+    def __cmp__(self, other):
+        """no i can not be a function"""
+        print(42)
+
+    def __copy__(self):
+        return 24
+
+    def __getstate__(self):
+        return 42
+
+
+class Prop(object):
+
+    @property
+    def count(self):
+        """Don't emit no-self-use for properties.
+
+        They can't be functions and they can be part of an
+        API specification.
+        """
+        return 42
diff --git a/tests/functional/n/no/no_self_use.txt b/tests/functional/n/no/no_self_use.txt
new file mode 100644
index 000000000..b14ee9e03
--- /dev/null
+++ b/tests/functional/n/no/no_self_use.txt
@@ -0,0 +1 @@
+no-self-use:16:4:Toto.function_method:Method could be a function
diff --git a/tests/functional/n/no/no_self_use_py3.py b/tests/functional/n/no/no_self_use_py3.py
new file mode 100644
index 000000000..f40150835
--- /dev/null
+++ b/tests/functional/n/no/no_self_use_py3.py
@@ -0,0 +1,12 @@
+# pylint: disable=missing-docstring,no-init,unused-argument,invalid-name,too-few-public-methods
+
+class A:
+    def __init__(self):
+        self.store = {}
+
+    def get(self, key, default=None):
+        return self.store.get(key, default)
+
+class B(A):
+    def get_memo(self, obj):
+        return super().get(obj)
diff --git a/tests/functional/n/no/no_self_use_py3.rc b/tests/functional/n/no/no_self_use_py3.rc
new file mode 100644
index 000000000..c093be204
--- /dev/null
+++ b/tests/functional/n/no/no_self_use_py3.rc
@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver=3.0
diff --git a/tests/functional/n/no/no_staticmethod_decorator.py b/tests/functional/n/no/no_staticmethod_decorator.py
new file mode 100644
index 000000000..d0e0effa4
--- /dev/null
+++ b/tests/functional/n/no/no_staticmethod_decorator.py
@@ -0,0 +1,35 @@
+"""Checks static methods are declared with a decorator if within the class
+scope and if static method's argument is a member of the class
+"""
+
+# pylint: disable=too-few-public-methods, using-constant-test, no-method-argument, useless-object-inheritance
+
+class MyClass(object):
+    """Some class"""
+    def __init__(self):
+        pass
+
+    def smethod():
+        """static method-to-be"""
+    smethod = staticmethod(smethod) # [no-staticmethod-decorator]
+
+    if True:
+        smethod = staticmethod(smethod)  # [no-staticmethod-decorator]
+
+    @staticmethod
+    def my_second_method():
+        """correct static method definition"""
+
+    def other_method():
+        """some method"""
+    smethod2 = staticmethod(other_method)  # [no-staticmethod-decorator]
+
+def helloworld():
+    """says hello"""
+
+
+MyClass.new_static_method = staticmethod(helloworld)
+
+class MyOtherClass(object):
+    """Some other class"""
+    _make = staticmethod(tuple.__new__)
diff --git a/tests/functional/n/no/no_staticmethod_decorator.txt b/tests/functional/n/no/no_staticmethod_decorator.txt
new file mode 100644
index 000000000..df897666a
--- /dev/null
+++ b/tests/functional/n/no/no_staticmethod_decorator.txt
@@ -0,0 +1,3 @@
+no-staticmethod-decorator:14:4:MyClass:Consider using a decorator instead of calling staticmethod
+no-staticmethod-decorator:17:8:MyClass:Consider using a decorator instead of calling staticmethod
+no-staticmethod-decorator:25:4:MyClass:Consider using a decorator instead of calling staticmethod