diff options
| -rw-r--r-- | ChangeLog | 2 | ||||
| -rw-r--r-- | pylint/config.py | 36 | ||||
| -rw-r--r-- | pylint/lint.py | 8 | ||||
| -rw-r--r-- | pylint/test/unittest_lint.py | 9 | ||||
| -rw-r--r-- | pylintrc | 4 |
5 files changed, 3 insertions, 56 deletions
@@ -260,6 +260,8 @@ ChangeLog for Pylint detected by the type checker for *all* the builtins and not as a special case for the reversed builtin. This will happen shortly in the future. + + * --comment flag was obsoleted and it will be removed in Pylint 1.6. diff --git a/pylint/config.py b/pylint/config.py index 213618e69..a821726fb 100644 --- a/pylint/config.py +++ b/pylint/config.py @@ -121,39 +121,3 @@ directory). Path to the configuration file. See the documentation for the method used to search for configuration file. ''' % globals() - -# evaluation messages ######################################################### - -def get_note_message(note): - """return a message according to note - note is a float < 10 (10 is the highest note) - """ - assert note <= 10, "Note is %.2f. Either you cheated, or pylint's \ -broken!" % note - if note < 0: - msg = 'You have to do something quick !' - elif note < 1: - msg = 'Hey! This is really dreadful. Or maybe pylint is buggy?' - elif note < 2: - msg = "Come on! You can't be proud of this code" - elif note < 3: - msg = 'Hum... Needs work.' - elif note < 4: - msg = 'Wouldn\'t you be a bit lazy?' - elif note < 5: - msg = 'A little more work would make it acceptable.' - elif note < 6: - msg = 'Just the bare minimum. Give it a bit more polish. ' - elif note < 7: - msg = 'This is okay-ish, but I\'m sure you can do better.' - elif note < 8: - msg = 'If you commit now, people should not be making nasty \ -comments about you on c.l.py' - elif note < 9: - msg = 'That\'s pretty good. Good work mate.' - elif note < 10: - msg = 'So close to being perfect...' - else: - msg = 'Wow ! Now this deserves our uttermost respect.\nPlease send \ -your code to python-projects@logilab.org' - return msg diff --git a/pylint/lint.py b/pylint/lint.py index 90772963a..5fd3d1023 100644 --- a/pylint/lint.py +++ b/pylint/lint.py @@ -325,11 +325,7 @@ class PyLinter(configuration.OptionsManagerMixIn, 'statements analyzed. This is used by the global ' 'evaluation report (RP0004).'}), - ('comment', - {'default': 0, 'type' : 'yn', 'metavar' : '<y_or_n>', - 'group': 'Reports', 'level': 1, - 'help' : 'Add a comment according to your evaluation note. ' - 'This is used by the global evaluation report (RP0004).'}), + ('comment', utils.deprecated_option(opt_type='yn')), ('confidence', {'type' : 'multiple_choice', 'metavar': '<levels>', @@ -1008,8 +1004,6 @@ class PyLinter(configuration.OptionsManagerMixIn, pnote = previous_stats.get('global_note') if pnote is not None: msg += ' (previous run: %.2f/10, %+.2f)' % (pnote, note - pnote) - if self.config.comment: - msg = '%s\n%s' % (msg, config.get_note_message(note)) sect.append(ureports.Text(msg)) # some reporting functions #################################################### diff --git a/pylint/test/unittest_lint.py b/pylint/test/unittest_lint.py index 77b88ab2c..309510865 100644 --- a/pylint/test/unittest_lint.py +++ b/pylint/test/unittest_lint.py @@ -67,15 +67,6 @@ def remove(file): except OSError: pass -class GetNoteMessageTC(unittest.TestCase): - def test(self): - msg = None - for note in range(-1, 11): - note_msg = config.get_note_message(note) - self.assertNotEqual(msg, note_msg) - msg = note_msg - - HERE = abspath(dirname(__file__)) INPUTDIR = join(HERE, 'input') @@ -87,10 +87,6 @@ reports=yes # (RP0004). evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) -# Add a comment according to your evaluation note. This is used by the global -# evaluation report (RP0004). -comment=no - # Template used to display messages. This is a python new-style format string # used to format the message information. See doc for all details #msg-template= |