diff options
Diffstat (limited to 'pylint/checkers/variables.py')
| -rw-r--r-- | pylint/checkers/variables.py | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py index a64b3ceab..c91880c24 100644 --- a/pylint/checkers/variables.py +++ b/pylint/checkers/variables.py @@ -214,11 +214,11 @@ def _detect_global_scope(node, frame, defframe): return False break_scopes = [] - for s in (scope, def_scope): + for current_scope in (scope, def_scope): # Look for parent scopes. If there is anything different # than a module or a class scope, then they frames don't # share a global scope. - parent_scope = s + parent_scope = current_scope while parent_scope: if not isinstance(parent_scope, (astroid.ClassDef, astroid.Module)): break_scopes.append(parent_scope) @@ -252,7 +252,6 @@ def _fix_dot_imports(not_consumed): like 'xml' (when we have both 'xml.etree' and 'xml.sax'), to 'xml.etree' and 'xml.sax' respectively. """ - # TODO: this should be improved in issue astroid #46 names = {} for name, stmts in not_consumed.items(): if any( @@ -984,7 +983,6 @@ class VariablesChecker(BaseChecker): return # Ignore names imported by the global statement. - # FIXME: should only ignore them if it's assigned latter if isinstance(stmt, (astroid.Global, astroid.Import, astroid.ImportFrom)): # Detect imports, assigned to global statements. if global_names and _import_name_is_global(stmt, global_names): @@ -1855,8 +1853,6 @@ class VariablesChecker(BaseChecker): except astroid.InferenceError: return None if module_names: - # FIXME: other message if name is not the latest part of - # module_names ? modname = module.name if module else "__dict__" self.add_message( "no-name-in-module", node=node, args=(".".join(module_names), modname) |