diff options
Diffstat (limited to 'pylint/test/unittest_utils.py')
| -rw-r--r-- | pylint/test/unittest_utils.py | 327 |
1 files changed, 202 insertions, 125 deletions
diff --git a/pylint/test/unittest_utils.py b/pylint/test/unittest_utils.py index e0c453dcd..7bdf502ba 100644 --- a/pylint/test/unittest_utils.py +++ b/pylint/test/unittest_utils.py @@ -40,47 +40,47 @@ class TestPyLintASTWalker(object): def __init__(self): self.called = set() - @check_messages('first-message') + @check_messages("first-message") def visit_module(self, module): - self.called.add('module') + self.called.add("module") - @check_messages('second-message') + @check_messages("second-message") def visit_call(self, module): raise NotImplementedError - @check_messages('second-message', 'third-message') + @check_messages("second-message", "third-message") def visit_assignname(self, module): - self.called.add('assignname') + self.called.add("assignname") - @check_messages('second-message') + @check_messages("second-message") def leave_assignname(self, module): raise NotImplementedError def test_check_messages(self): - linter = self.MockLinter({'first-message': True, - 'second-message': False, - 'third-message': True}) + linter = self.MockLinter( + {"first-message": True, "second-message": False, "third-message": True} + ) walker = utils.PyLintASTWalker(linter) checker = self.Checker() walker.add_checker(checker) walker.walk(astroid.parse("x = func()")) - assert {'module', 'assignname'} == checker.called + assert {"module", "assignname"} == checker.called def test_deprecated_methods(self): class Checker(object): def __init__(self): self.called = False - @check_messages('first-message') + @check_messages("first-message") def visit_assname(self, node): self.called = True - linter = self.MockLinter({'first-message': True}) + linter = self.MockLinter({"first-message": True}) walker = utils.PyLintASTWalker(linter) checker = Checker() walker.add_checker(checker) with warnings.catch_warnings(record=True): - warnings.simplefilter('always') + warnings.simplefilter("always") walker.walk(astroid.parse("x = 1")) assert not checker.called @@ -103,52 +103,112 @@ def store(): return utils.MessagesStore() -@pytest.mark.parametrize("messages,expected", [ - ({'W1234': ('message one', 'msg-symbol-one', 'msg description'), - 'W4321': ('message two', 'msg-symbol-two', 'msg description')}, - r"Inconsistent checker part in message id 'W4321' (expected 'x12xx' because we already had ['W1234'])."), - - ({'W1233': ('message two', 'msg-symbol-two', 'msg description', - {'old_names': [('W1234', 'old-symbol')]}), - 'W1234': ('message one', 'msg-symbol-one', 'msg description')}, - "Message id 'W1234' cannot have both 'old-symbol' and 'msg-symbol-one' as symbolic name."), - - ({'W1234': ('message one', 'msg-symbol-one', 'msg description'), - 'W1235': ('message two', 'msg-symbol-two', 'msg description', - {'old_names': [('W1234', 'old-symbol')]})}, - "Message id 'W1234' cannot have both 'msg-symbol-one' and 'old-symbol' as symbolic name."), - - ({'W1234': ('message one', 'msg-symbol-one', 'msg description', - {'old_names': [('W1201', 'old-symbol-one')]}), - 'W1235': ('message two', 'msg-symbol-two', 'msg description', - {'old_names': [('W1201', 'old-symbol-two')]})}, - "Message id 'W1201' cannot have both 'old-symbol-one' and 'old-symbol-two' as symbolic name."), - - ({'W1234': ('message one', 'msg-symbol', 'msg description'), - 'W1235': ('message two', 'msg-symbol', 'msg description')}, - "Message symbol 'msg-symbol' cannot be used for 'W1234' and 'W1235' at the same time."), - - ({'W1233': ('message two', 'msg-symbol-two', 'msg description', - {'old_names': [('W1230', 'msg-symbol-one')]}), - 'W1234': ('message one', 'msg-symbol-one', 'msg description')}, - "Message symbol 'msg-symbol-one' cannot be used for 'W1230' and 'W1234' at the same time."), - - ({'W1234': ('message one', 'msg-symbol-one', 'msg description'), - 'W1235': ('message two', 'msg-symbol-two', 'msg description', - {'old_names': [('W1230', 'msg-symbol-one')]})}, - "Message symbol 'msg-symbol-one' cannot be used for 'W1234' and 'W1235' at the same time."), - - ({'W1234': ('message one', 'msg-symbol-one', 'msg description', - {'old_names': [('W1230', 'old-symbol-one')]}), - 'W1235': ('message two', 'msg-symbol-two', 'msg description', - {'old_names': [('W1231', 'old-symbol-one')]})}, - "Message symbol 'old-symbol-one' cannot be used for 'W1230' and 'W1235' at the same time."), - -]) +@pytest.mark.parametrize( + "messages,expected", + [ + ( + { + "W1234": ("message one", "msg-symbol-one", "msg description"), + "W4321": ("message two", "msg-symbol-two", "msg description"), + }, + r"Inconsistent checker part in message id 'W4321' (expected 'x12xx' because we already had ['W1234']).", + ), + ( + { + "W1233": ( + "message two", + "msg-symbol-two", + "msg description", + {"old_names": [("W1234", "old-symbol")]}, + ), + "W1234": ("message one", "msg-symbol-one", "msg description"), + }, + "Message id 'W1234' cannot have both 'old-symbol' and 'msg-symbol-one' as symbolic name.", + ), + ( + { + "W1234": ("message one", "msg-symbol-one", "msg description"), + "W1235": ( + "message two", + "msg-symbol-two", + "msg description", + {"old_names": [("W1234", "old-symbol")]}, + ), + }, + "Message id 'W1234' cannot have both 'msg-symbol-one' and 'old-symbol' as symbolic name.", + ), + ( + { + "W1234": ( + "message one", + "msg-symbol-one", + "msg description", + {"old_names": [("W1201", "old-symbol-one")]}, + ), + "W1235": ( + "message two", + "msg-symbol-two", + "msg description", + {"old_names": [("W1201", "old-symbol-two")]}, + ), + }, + "Message id 'W1201' cannot have both 'old-symbol-one' and 'old-symbol-two' as symbolic name.", + ), + ( + { + "W1234": ("message one", "msg-symbol", "msg description"), + "W1235": ("message two", "msg-symbol", "msg description"), + }, + "Message symbol 'msg-symbol' cannot be used for 'W1234' and 'W1235' at the same time.", + ), + ( + { + "W1233": ( + "message two", + "msg-symbol-two", + "msg description", + {"old_names": [("W1230", "msg-symbol-one")]}, + ), + "W1234": ("message one", "msg-symbol-one", "msg description"), + }, + "Message symbol 'msg-symbol-one' cannot be used for 'W1230' and 'W1234' at the same time.", + ), + ( + { + "W1234": ("message one", "msg-symbol-one", "msg description"), + "W1235": ( + "message two", + "msg-symbol-two", + "msg description", + {"old_names": [("W1230", "msg-symbol-one")]}, + ), + }, + "Message symbol 'msg-symbol-one' cannot be used for 'W1234' and 'W1235' at the same time.", + ), + ( + { + "W1234": ( + "message one", + "msg-symbol-one", + "msg description", + {"old_names": [("W1230", "old-symbol-one")]}, + ), + "W1235": ( + "message two", + "msg-symbol-two", + "msg description", + {"old_names": [("W1231", "old-symbol-one")]}, + ), + }, + "Message symbol 'old-symbol-one' cannot be used for 'W1230' and 'W1235' at the same time.", + ), + ], +) def test_register_error(store, messages, expected): class Checker(object): - name = 'checker' + name = "checker" msgs = messages + with pytest.raises(InvalidMessageError) as cm: store.register_messages(Checker()) assert str(cm.value) == expected @@ -156,32 +216,31 @@ def test_register_error(store, messages, expected): def test_register_error_new_id_duplicate_of_new(store): class CheckerOne(object): - name = 'checker_one' - msgs = { - 'W1234': ('message one', 'msg-symbol-one', 'msg description.'), - } + name = "checker_one" + msgs = {"W1234": ("message one", "msg-symbol-one", "msg description.")} class CheckerTwo(object): - name = 'checker_two' - msgs = { - 'W1234': ('message two', 'msg-symbol-two', 'another msg description.'), - } + name = "checker_two" + msgs = {"W1234": ("message two", "msg-symbol-two", "another msg description.")} store.register_messages(CheckerOne()) test_register_error( - store, {'W1234': ('message two', 'msg-symbol-two', 'another msg description.')}, - "Message id 'W1234' cannot have both 'msg-symbol-one' and 'msg-symbol-two' as symbolic name." + store, + {"W1234": ("message two", "msg-symbol-two", "another msg description.")}, + "Message id 'W1234' cannot have both 'msg-symbol-one' and 'msg-symbol-two' as symbolic name.", ) -@pytest.mark.parametrize("msgid,expected", [ - ("Q1234", "Bad message type Q in 'Q1234'"), - ("W12345", "Invalid message id 'W12345'"), -]) +@pytest.mark.parametrize( + "msgid,expected", + [ + ("Q1234", "Bad message type Q in 'Q1234'"), + ("W12345", "Invalid message id 'W12345'"), + ], +) def test_create_invalid_message_type(msgid, expected): with pytest.raises(InvalidMessageError) as cm: - utils.MessageDefinition('checker', msgid, - 'msg', 'descr', 'symbol', 'scope') + utils.MessageDefinition("checker", msgid, "msg", "descr", "symbol", "scope") assert str(cm.value) == expected @@ -189,98 +248,107 @@ def test_decoding_stream_unknown_encoding(): """decoding_stream should fall back to *some* decoding when given an unknown encoding. """ - binary_io = io.BytesIO(b'foo\nbar') - stream = utils.decoding_stream(binary_io, 'garbage-encoding') + binary_io = io.BytesIO(b"foo\nbar") + stream = utils.decoding_stream(binary_io, "garbage-encoding") # should still act like a StreamReader ret = stream.readlines() - assert ret == ['foo\n', 'bar'] + assert ret == ["foo\n", "bar"] def test_decoding_stream_known_encoding(): - binary_io = io.BytesIO('€'.encode('cp1252')) - stream = utils.decoding_stream(binary_io, 'cp1252') - assert stream.read() == '€' + binary_io = io.BytesIO("€".encode("cp1252")) + stream = utils.decoding_stream(binary_io, "cp1252") + assert stream.read() == "€" -class TestGetNodeLastLineno: +class TestGetNodeLastLineno: def test_get_node_last_lineno_simple(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ pass - """) + """ + ) assert get_node_last_lineno(node) == 2 - def test_get_node_last_lineno_if_simple(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ if True: print(1) pass - """) + """ + ) assert get_node_last_lineno(node) == 4 - def test_get_node_last_lineno_if_elseif_else(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ if True: print(1) elif False: print(2) else: print(3) - """) + """ + ) assert get_node_last_lineno(node) == 7 - def test_get_node_last_lineno_while(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ while True: print(1) - """) + """ + ) assert get_node_last_lineno(node) == 3 - def test_get_node_last_lineno_while_else(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ while True: print(1) else: print(2) - """) + """ + ) assert get_node_last_lineno(node) == 5 - def test_get_node_last_lineno_for(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ for x in range(0, 5): print(1) - """) + """ + ) assert get_node_last_lineno(node) == 3 - def test_get_node_last_lineno_for_else(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ for x in range(0, 5): print(1) else: print(2) - """) + """ + ) assert get_node_last_lineno(node) == 5 - def test_get_node_last_lineno_try(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ try: print(1) except ValueError: print(2) except Exception: print(3) - """) + """ + ) assert get_node_last_lineno(node) == 7 - def test_get_node_last_lineno_try_except_else(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ try: print(1) except Exception: @@ -288,24 +356,26 @@ class TestGetNodeLastLineno: print(3) else: print(4) - """) + """ + ) assert get_node_last_lineno(node) == 8 - def test_get_node_last_lineno_try_except_finally(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ try: print(1) except Exception: print(2) finally: print(4) - """) + """ + ) assert get_node_last_lineno(node) == 7 - def test_get_node_last_lineno_try_except_else_finally(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ try: print(1) except Exception: @@ -314,39 +384,44 @@ class TestGetNodeLastLineno: print(3) finally: print(4) - """) + """ + ) assert get_node_last_lineno(node) == 9 - def test_get_node_last_lineno_with(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ with x as y: print(1) pass - """) + """ + ) assert get_node_last_lineno(node) == 4 - def test_get_node_last_lineno_method(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ def x(a, b): print(a, b) pass - """) + """ + ) assert get_node_last_lineno(node) == 4 - def test_get_node_last_lineno_decorator(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ @decor() def x(a, b): print(a, b) pass - """) + """ + ) assert get_node_last_lineno(node) == 5 def test_get_node_last_lineno_class(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ class C(object): CONST = True @@ -356,12 +431,13 @@ class TestGetNodeLastLineno: def y(self): pass pass - """) + """ + ) assert get_node_last_lineno(node) == 10 - def test_get_node_last_lineno_combined(self): - node = astroid.extract_node(""" + node = astroid.extract_node( + """ class C(object): CONST = True @@ -372,5 +448,6 @@ class TestGetNodeLastLineno: pass finally: pass - """) + """ + ) assert get_node_last_lineno(node) == 11 |