diff options
Diffstat (limited to 'tests/functional/redundant_unittest_assert.py')
-rw-r--r-- | tests/functional/redundant_unittest_assert.py | 38 |
1 files changed, 38 insertions, 0 deletions
diff --git a/tests/functional/redundant_unittest_assert.py b/tests/functional/redundant_unittest_assert.py new file mode 100644 index 000000000..2eb73e3d4 --- /dev/null +++ b/tests/functional/redundant_unittest_assert.py @@ -0,0 +1,38 @@ +# pylint: disable=missing-docstring,too-few-public-methods +""" +http://www.logilab.org/ticket/355 +If you are using assertTrue or assertFalse and the first argument is a +constant(like a string), then the assert will always be true. Therefore, +it should emit a warning message. +""" + +import unittest + +@unittest.skip("don't run this") +class Tests(unittest.TestCase): + def test_something(self): + ''' Simple test ''' + some_var = 'It should be assertEqual' + # +1:[redundant-unittest-assert] + self.assertTrue('I meant assertEqual not assertTrue', some_var) + # +1:[redundant-unittest-assert] + self.assertFalse('I meant assertEqual not assertFalse', some_var) + # +1:[redundant-unittest-assert] + self.assertTrue(True, some_var) + # +1:[redundant-unittest-assert] + self.assertFalse(False, some_var) + # +1:[redundant-unittest-assert] + self.assertFalse(None, some_var) + # +1:[redundant-unittest-assert] + self.assertTrue(0, some_var) + + self.assertTrue('should be' in some_var, some_var) + self.assertTrue(some_var, some_var) + + +@unittest.skip("don't run this") +class RegressionWithArgs(unittest.TestCase): + '''Don't fail if the bound method doesn't have arguments.''' + + def test(self): + self.run() |