From ccd29745013df4c4480ca8b6ccc3e655ab2478fb Mon Sep 17 00:00:00 2001 From: yushao2 <36848472+yushao2@users.noreply.github.com> Date: Fri, 19 Nov 2021 08:26:18 +0800 Subject: Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Daniƫl van Noord <13665637+DanielNoord@users.noreply.github.com> --- pylint/checkers/refactoring/recommendation_checker.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pylint/checkers/refactoring/recommendation_checker.py b/pylint/checkers/refactoring/recommendation_checker.py index 1c484bb59..96c04b92f 100644 --- a/pylint/checkers/refactoring/recommendation_checker.py +++ b/pylint/checkers/refactoring/recommendation_checker.py @@ -83,10 +83,10 @@ class RecommendationChecker(checkers.BaseChecker): return if node.func.attrname != "keys": return - comp_ancestor = utils.get_node_first_ancestor_of_type(node, nodes.Compare) + comp_ancestor = utils.get_node_first_ancestor_of_type(node, (nodes.Compare,)) if ( isinstance(node.parent, (nodes.For, nodes.Comprehension)) - or isinstance(comp_ancestor, nodes.Compare) + or comp_ancestor and any( op for op, comparator in comp_ancestor.ops -- cgit v1.2.1