From ff8cdd2b4096c44854731aba556f8a948ff9b3c4 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 27 Feb 2023 08:05:48 +0100 Subject: [test] Use an empty pylintrc so tests to not depend on system's conf (#8350) (#8351) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [test] Use an empty pylintrc so tests to not depend on system's conf Closes #8342 * Update tests/checkers/unittest_imports.py Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> --------- Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> (cherry picked from commit 641f526e1632dd1835b79abaf31006efc60824f6) Co-authored-by: Pierre Sassoulas --- tests/checkers/unittest_imports.py | 5 +++-- tests/config/pylint_config/test_pylint_config_generate.py | 10 +++++++++- tests/config/test_per_directory_config.py | 2 +- tests/test_pylint_runners.py | 2 +- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/checkers/unittest_imports.py b/tests/checkers/unittest_imports.py index 04eadcf1c..40e504c49 100644 --- a/tests/checkers/unittest_imports.py +++ b/tests/checkers/unittest_imports.py @@ -11,8 +11,8 @@ from pytest import CaptureFixture from pylint.checkers import imports from pylint.interfaces import UNDEFINED -from pylint.lint import Run from pylint.testutils import CheckerTestCase, MessageTest +from pylint.testutils._run import _Run as Run REGR_DATA = os.path.join(os.path.dirname(__file__), "..", "regrtest_data", "") @@ -152,7 +152,7 @@ class TestImportsChecker(CheckerTestCase): exit=False, ) output, errors = capsys.readouterr() - assert len(output.split("\n")) == 5, f"Expected 5 line breaks in:{output}" + assert len(output.split("\n")) == 7, f"Expected 7 line breaks in:{output}" assert ( "__init__.py:1:0: C0414: Import alias does not rename original package (useless-import-alias)" in output @@ -168,6 +168,7 @@ class TestImportsChecker(CheckerTestCase): [ f"{os.path.join(REGR_DATA, 'allow_reexport')}", "--allow-reexport-from-package=yes", + "--disable=missing-module-docstring", "-sn", ], exit=False, diff --git a/tests/config/pylint_config/test_pylint_config_generate.py b/tests/config/pylint_config/test_pylint_config_generate.py index 65fc05557..adf7129a5 100644 --- a/tests/config/pylint_config/test_pylint_config_generate.py +++ b/tests/config/pylint_config/test_pylint_config_generate.py @@ -186,7 +186,15 @@ def test_writing_minimal_file( assert any(line.startswith("#") for line in captured.out.splitlines()) # Check minimal doesn't have comments and no default values - Run(["--accept-no-return-doc=y", "generate", "--interactive"], exit=False) + Run( + [ + "--load-plugins=pylint.extensions.docparams", + "--accept-no-return-doc=y", + "generate", + "--interactive", + ], + exit=False, + ) captured = capsys.readouterr() assert not any(i.startswith("#") for i in captured.out.split("\n")) assert "accept-no-return-doc" not in captured.out diff --git a/tests/config/test_per_directory_config.py b/tests/config/test_per_directory_config.py index e0bf75e70..85d918a21 100644 --- a/tests/config/test_per_directory_config.py +++ b/tests/config/test_per_directory_config.py @@ -4,7 +4,7 @@ from pathlib import Path -from pylint.lint import Run +from pylint.testutils._run import _Run as Run def test_fall_back_on_base_config(tmp_path: Path) -> None: diff --git a/tests/test_pylint_runners.py b/tests/test_pylint_runners.py index 06a16c3a5..6a55db9eb 100644 --- a/tests/test_pylint_runners.py +++ b/tests/test_pylint_runners.py @@ -18,8 +18,8 @@ from unittest.mock import MagicMock, mock_open, patch import pytest from pylint import run_epylint, run_pylint, run_pyreverse, run_symilar -from pylint.lint import Run from pylint.testutils import GenericTestReporter as Reporter +from pylint.testutils._run import _Run as Run from pylint.testutils.utils import _test_cwd if sys.version_info >= (3, 8): -- cgit v1.2.1