From f963868f6b46d31ef7ae1bd1196eafe50bc4bad7 Mon Sep 17 00:00:00 2001 From: Tim Martin Date: Wed, 6 Oct 2021 20:56:32 +0100 Subject: Fix a crash if ``str.format`` is referenced without being called (#5109) Closes #5058 Co-authored-by: Pierre Sassoulas --- pylint/checkers/refactoring/recommendation_checker.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'pylint/checkers/refactoring/recommendation_checker.py') diff --git a/pylint/checkers/refactoring/recommendation_checker.py b/pylint/checkers/refactoring/recommendation_checker.py index 81a7dd7b1..3bccd5fcb 100644 --- a/pylint/checkers/refactoring/recommendation_checker.py +++ b/pylint/checkers/refactoring/recommendation_checker.py @@ -341,8 +341,8 @@ class RecommendationChecker(checkers.BaseChecker): isinstance(node.parent, nodes.Attribute) and node.parent.attrname == "format" ): - # Allow assigning .format to a variable - if isinstance(node.parent.parent, nodes.Assign): + # Don't warn on referencing / assigning .format without calling it + if not isinstance(node.parent.parent, nodes.Call): return if node.parent.parent.args: -- cgit v1.2.1