From 918f4624d76197bec7cc54467f0281ff63c19c5a Mon Sep 17 00:00:00 2001 From: Pierre Sassoulas Date: Wed, 26 Apr 2023 21:50:45 +0200 Subject: Merge the empty-string extensions to 'implicit_booleaness_checker' --- .../ext/emptystring/empty_string_comparison.py | 22 ---------------------- .../ext/emptystring/empty_string_comparison.rc | 2 -- .../ext/emptystring/empty_string_comparison.txt | 6 ------ ...implicit_booleaness_not_comparison_to_string.py | 22 ++++++++++++++++++++++ ...implicit_booleaness_not_comparison_to_string.rc | 2 ++ ...mplicit_booleaness_not_comparison_to_string.txt | 6 ++++++ 6 files changed, 30 insertions(+), 30 deletions(-) delete mode 100644 tests/functional/ext/emptystring/empty_string_comparison.py delete mode 100644 tests/functional/ext/emptystring/empty_string_comparison.rc delete mode 100644 tests/functional/ext/emptystring/empty_string_comparison.txt create mode 100644 tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.py create mode 100644 tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.rc create mode 100644 tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.txt (limited to 'tests') diff --git a/tests/functional/ext/emptystring/empty_string_comparison.py b/tests/functional/ext/emptystring/empty_string_comparison.py deleted file mode 100644 index b61caeff6..000000000 --- a/tests/functional/ext/emptystring/empty_string_comparison.py +++ /dev/null @@ -1,22 +0,0 @@ -# pylint: disable=literal-comparison,missing-docstring - -X = '' -Y = 'test' - -if X is '': # [compare-to-empty-string] - pass - -if Y is not "": # [compare-to-empty-string] - pass - -if X == "": # [compare-to-empty-string] - pass - -if Y != '': # [compare-to-empty-string] - pass - -if "" == Y: # [compare-to-empty-string] - pass - -if '' != X: # [compare-to-empty-string] - pass diff --git a/tests/functional/ext/emptystring/empty_string_comparison.rc b/tests/functional/ext/emptystring/empty_string_comparison.rc deleted file mode 100644 index d2826befa..000000000 --- a/tests/functional/ext/emptystring/empty_string_comparison.rc +++ /dev/null @@ -1,2 +0,0 @@ -[MAIN] -load-plugins=pylint.extensions.emptystring, diff --git a/tests/functional/ext/emptystring/empty_string_comparison.txt b/tests/functional/ext/emptystring/empty_string_comparison.txt deleted file mode 100644 index be9c91bc5..000000000 --- a/tests/functional/ext/emptystring/empty_string_comparison.txt +++ /dev/null @@ -1,6 +0,0 @@ -compare-to-empty-string:6:3:6:10::"""X is ''"" can be simplified to ""not X"" as an empty string is falsey":HIGH -compare-to-empty-string:9:3:9:14::"""Y is not ''"" can be simplified to ""Y"" as an empty string is falsey":HIGH -compare-to-empty-string:12:3:12:10::"""X == ''"" can be simplified to ""not X"" as an empty string is falsey":HIGH -compare-to-empty-string:15:3:15:10::"""Y != ''"" can be simplified to ""Y"" as an empty string is falsey":HIGH -compare-to-empty-string:18:3:18:10::"""'' == Y"" can be simplified to ""not Y"" as an empty string is falsey":HIGH -compare-to-empty-string:21:3:21:10::"""'' != X"" can be simplified to ""X"" as an empty string is falsey":HIGH diff --git a/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.py b/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.py new file mode 100644 index 000000000..4fbf0fc1d --- /dev/null +++ b/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.py @@ -0,0 +1,22 @@ +# pylint: disable=literal-comparison,missing-docstring + +X = '' +Y = 'test' + +if X is '': # [use-implicit-booleaness-not-comparison-to-string] + pass + +if Y is not "": # [use-implicit-booleaness-not-comparison-to-string] + pass + +if X == "": # [use-implicit-booleaness-not-comparison-to-string] + pass + +if Y != '': # [use-implicit-booleaness-not-comparison-to-string] + pass + +if "" == Y: # [use-implicit-booleaness-not-comparison-to-string] + pass + +if '' != X: # [use-implicit-booleaness-not-comparison-to-string] + pass diff --git a/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.rc b/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.rc new file mode 100644 index 000000000..14648884d --- /dev/null +++ b/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.rc @@ -0,0 +1,2 @@ +[MAIN] +enable=use-implicit-booleaness-not-comparison-to-string diff --git a/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.txt b/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.txt new file mode 100644 index 000000000..c1f31f27f --- /dev/null +++ b/tests/functional/u/use/use_implicit_booleaness_not_comparison_to_string.txt @@ -0,0 +1,6 @@ +use-implicit-booleaness-not-comparison-to-string:6:3:6:10::"""X is ''"" can be simplified to ""not X"" as an empty string is falsey":HIGH +use-implicit-booleaness-not-comparison-to-string:9:3:9:14::"""Y is not ''"" can be simplified to ""Y"" as an empty string is falsey":HIGH +use-implicit-booleaness-not-comparison-to-string:12:3:12:10::"""X == ''"" can be simplified to ""not X"" as an empty string is falsey":HIGH +use-implicit-booleaness-not-comparison-to-string:15:3:15:10::"""Y != ''"" can be simplified to ""Y"" as an empty string is falsey":HIGH +use-implicit-booleaness-not-comparison-to-string:18:3:18:10::"""'' == Y"" can be simplified to ""not Y"" as an empty string is falsey":HIGH +use-implicit-booleaness-not-comparison-to-string:21:3:21:10::"""'' != X"" can be simplified to ""X"" as an empty string is falsey":HIGH -- cgit v1.2.1