1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
|
# pylint: disable=missing-docstring, missing-module-docstring, invalid-name
# pylint: disable=too-few-public-methods, line-too-long, dangerous-default-value
# https://github.com/PyCQA/pylint/issues/4774
def github_issue_4774():
# Test literals
# https://github.com/PyCQA/pylint/issues/4774
good_list = []
if not good_list:
pass
bad_list = []
if bad_list == []: # [use-implicit-booleaness-not-comparison]
pass
# Testing for empty literals
empty_tuple = ()
empty_list = []
empty_dict = {}
if empty_tuple == (): # [use-implicit-booleaness-not-comparison]
pass
if empty_list == []: # [use-implicit-booleaness-not-comparison]
pass
if empty_dict == {}: # [use-implicit-booleaness-not-comparison]
pass
if () == empty_tuple: # [use-implicit-booleaness-not-comparison]
pass
if [] == empty_list: # [use-implicit-booleaness-not-comparison]
pass
if {} == empty_dict: # [use-implicit-booleaness-not-comparison]
pass
def bad_tuple_return():
t = (1, )
return t == () # [use-implicit-booleaness-not-comparison]
def bad_list_return():
b = [1]
return b == [] # [use-implicit-booleaness-not-comparison]
def bad_dict_return():
c = {1: 1}
return c == {} # [use-implicit-booleaness-not-comparison]
assert () == empty_tuple # [use-implicit-booleaness-not-comparison]
assert [] == empty_list # [use-implicit-booleaness-not-comparison]
assert {} != empty_dict # [use-implicit-booleaness-not-comparison]
assert () < empty_tuple # [use-implicit-booleaness-not-comparison]
assert [] <= empty_list # [use-implicit-booleaness-not-comparison]
assert () > empty_tuple # [use-implicit-booleaness-not-comparison]
assert [] >= empty_list # [use-implicit-booleaness-not-comparison]
assert [] == []
assert {} != {}
assert () == ()
d = {}
if d in {}:
pass
class NoBool:
def __init__(self):
self.a = 2
class YesBool:
def __init__(self):
self.a = True
def __bool__(self):
return self.a
# Should be triggered
a = NoBool()
if [] == a: # [use-implicit-booleaness-not-comparison]
pass
a = YesBool()
if a == []:
pass
# compound test cases
e = []
f = {}
if e == [] and f == {}: # [use-implicit-booleaness-not-comparison, use-implicit-booleaness-not-comparison]
pass
named_fields = [0, "", "42", "forty two"]
empty = any(field == "" for field in named_fields)
something_else = NoBool()
empty_literals = [[], {}, ()]
is_empty = any(field == something_else for field in empty_literals)
# this should work, but it doesn't since, input parameter only get the latest one, not all when inferred()
h, i, j = 1, None, [1,2,3]
def test(k):
print(k == {})
def test_with_default(k={}):
print(k == {}) # [use-implicit-booleaness-not-comparison]
print(k == 1)
test(h)
test(i)
test(j)
test_with_default(h)
test_with_default(i)
test_with_default(j)
# pylint: disable=import-outside-toplevel, wrong-import-position, import-error
# Numpy has its own implementation of __bool__, but base class has list, that's why the comparison check is happening
import numpy
numpy_array = numpy.array([0])
if numpy_array == []: # [use-implicit-booleaness-not-comparison]
print('numpy_array')
if numpy_array != []: # [use-implicit-booleaness-not-comparison]
print('numpy_array')
if numpy_array >= (): # [use-implicit-booleaness-not-comparison]
print('b')
# pandas has its own implementations of __bool__ and is not subclass of list, dict, or tuple; that's why comparison check is not happening
import pandas as pd
pandas_df = pd.DataFrame()
if pandas_df == []:
pass
if pandas_df != ():
pass
if pandas_df <= []:
print("truth value of a dataframe is ambiguous")
|
