blob: d686f4658ad1d98a2441d983575115e1ad691134 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
|
"""Check for else branches on loops with break and return only."""
from __future__ import print_function
__revision__ = 0
def test_return_for():
"""else + return is not accetable."""
for i in range(10):
if i % 2:
return i
else: # [useless-else-on-loop]
print('math is broken')
return None
def test_return_while():
"""else + return is not accetable."""
while True:
return 1
else: # [useless-else-on-loop]
print('math is broken')
return None
while True:
def short_fun():
"""A function with a loop."""
for _ in range(10):
break
else: # [useless-else-on-loop]
print('or else!')
while True:
while False:
break
else: # [useless-else-on-loop]
print('or else!')
for j in range(10):
pass
else: # [useless-else-on-loop]
print('fat chance')
for j in range(10):
break
def test_return_for2():
"""no false positive for break in else
https://bitbucket.org/logilab/pylint/issue/117/useless-else-on-loop-false-positives
"""
for i in range(10):
for _ in range(i):
if i % 2:
break
else:
break
else:
print('great math')
def test_break_in_orelse_deep():
"""no false positive for break in else deeply nested
"""
for _ in range(10):
if 1 < 2:
for _ in range(3):
if 3 < 2:
break
else:
break
else:
return True
return False
def test_break_in_orelse_deep2():
"""should rise a useless-else-on-loop message, as the break statement is only
for the inner for loop
"""
for _ in range(10):
if 1 < 2:
for _ in range(3):
if 3 < 2:
break
else:
print("all right")
else: # [useless-else-on-loop]
return True
return False
def test_break_in_orelse_deep3():
"""no false positive for break deeply nested in else
"""
for _ in range(10):
for _ in range(3):
pass
else:
if 1 < 2:
break
else:
return True
return False
|
