diff options
| author | Claudiu Popa <pcmanticore@gmail.com> | 2015-10-26 15:50:14 +0000 |
|---|---|---|
| committer | Claudiu Popa <pcmanticore@gmail.com> | 2015-10-26 15:50:14 +0000 |
| commit | ff0050ddc420f559dcae414b5944eec20b70103a (patch) | |
| tree | 92404dc90bb1fe306749f1dcc15bf8987a9a9aa8 | |
| parent | ad6b806b7256440ef030358106214bd9d6259a1c (diff) | |
| download | pylint-ff0050ddc420f559dcae414b5944eec20b70103a.tar.gz | |
Make misplaced-comparison-constant a convention, rather than a warning.
| -rw-r--r-- | pylint/checkers/base.py | 2 | ||||
| -rw-r--r-- | pylint/test/functional/misplaced_comparison_constant.py | 6 | ||||
| -rw-r--r-- | pylint/test/input/func_excess_escapes.py | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/pylint/checkers/base.py b/pylint/checkers/base.py index 234737e..87d1a4d 100644 --- a/pylint/checkers/base.py +++ b/pylint/checkers/base.py @@ -1465,7 +1465,7 @@ class ComparisonChecker(_BasicChecker): 'singleton-comparison', 'Used when an expression is compared to singleton ' 'values like True, False or None.'), - 'W0151': ('Comparison should be %s', + 'C0151': ('Comparison should be %s', 'misplaced-comparison-constant', 'Used when the constant is placed on the left side' 'of a comparison'), diff --git a/pylint/test/functional/misplaced_comparison_constant.py b/pylint/test/functional/misplaced_comparison_constant.py index df3f40e..49fffa9 100644 --- a/pylint/test/functional/misplaced_comparison_constant.py +++ b/pylint/test/functional/misplaced_comparison_constant.py @@ -17,13 +17,13 @@ def bad_comparisons(): instance = MyClass() for i in range(10): if 5 <= i: # [misplaced-comparison-constant] - print "foo" + pass if True == True: # [misplaced-comparison-constant] pass if 'bar' != 'foo': # [misplaced-comparison-constant] pass if 1 == i: # [misplaced-comparison-constant] - print "bar" + pass if 3 < dummy_return(): # [misplaced-comparison-constant] pass if 4 != instance.dummy_return(): # [misplaced-comparison-constant] @@ -35,4 +35,4 @@ def good_comparison(): """this is ok""" for i in range(10): if i == 5: - print "foo" + pass diff --git a/pylint/test/input/func_excess_escapes.py b/pylint/test/input/func_excess_escapes.py index 7b69832..12ac862 100644 --- a/pylint/test/input/func_excess_escapes.py +++ b/pylint/test/input/func_excess_escapes.py @@ -1,4 +1,4 @@ -# pylint:disable=W0105, W0511, W0151 +# pylint:disable=W0105, W0511, misplaced-comparison-constant """Stray backslash escapes may be missing a raw-string prefix.""" __revision__ = '$Id$' |