diff options
| author | Laura M?dioni <laura.medioni@logilab.fr> | 2015-10-27 09:36:29 +0100 |
|---|---|---|
| committer | Laura M?dioni <laura.medioni@logilab.fr> | 2015-10-27 09:36:29 +0100 |
| commit | 49b2cf899172af6a58e75547683fa8dc4b5fe6c3 (patch) | |
| tree | 4fd52288193717f4647fcc49adc8755c9cb618f0 | |
| parent | 3820ddea785c532428642ae2f96d9e8bff244fbf (diff) | |
| download | pylint-49b2cf899172af6a58e75547683fa8dc4b5fe6c3.tar.gz | |
improve unneeded-not messages
- warning => convention
- "One not too many" => "consider changing.."
| -rw-r--r-- | pylint/checkers/base.py | 4 | ||||
| -rw-r--r-- | pylint/test/functional/unneeded_not.txt | 24 |
2 files changed, 14 insertions, 14 deletions
diff --git a/pylint/checkers/base.py b/pylint/checkers/base.py index e8a4396..75a4d7f 100644 --- a/pylint/checkers/base.py +++ b/pylint/checkers/base.py @@ -1844,12 +1844,12 @@ class ElifChecker(BaseTokenChecker): self.config.max_nested_blocks)) class NotChecker(_BasicChecker): - """checks for nots too many in comparison expressions + """checks for too many not in comparison expressions - "not not" should trigger a warning - "not" followed by a comparison should trigger a warning """ - msgs = {'W0126': ('One not too many in "%s", should be "%s"', + msgs = {'C0113': ('Consider changing "%s" to "%s"', 'unneeded-not', 'Used when a boolean expression contains an unneeded ' 'negation.'), diff --git a/pylint/test/functional/unneeded_not.txt b/pylint/test/functional/unneeded_not.txt index 83100a4..cf27618 100644 --- a/pylint/test/functional/unneeded_not.txt +++ b/pylint/test/functional/unneeded_not.txt @@ -1,12 +1,12 @@ -unneeded-not:10:unneeded_not:One not too many in "not not bool_var", should be "bool_var" -unneeded-not:12:unneeded_not:One not too many in "not someint == 1", should be "someint != 1" -unneeded-not:14:unneeded_not:One not too many in "not someint != 1", should be "someint == 1" -unneeded-not:16:unneeded_not:One not too many in "not someint < 1", should be "someint >= 1" -unneeded-not:18:unneeded_not:One not too many in "not someint > 1", should be "someint <= 1" -unneeded-not:20:unneeded_not:One not too many in "not someint <= 1", should be "someint > 1" -unneeded-not:22:unneeded_not:One not too many in "not someint >= 1", should be "someint < 1" -unneeded-not:24:unneeded_not:One not too many in "not not someint", should be "someint" -unneeded-not:26:unneeded_not:One not too many in "not bool_var == True", should be "bool_var != True" -unneeded-not:28:unneeded_not:One not too many in "not bool_var == False", should be "bool_var != False" -unneeded-not:30:unneeded_not:One not too many in "not bool_var != True", should be "bool_var == True" -unneeded-not:32:unneeded_not:One not too many in "not True == True", should be "True != True" +unneeded-not:10:unneeded_not:Consider changing "not not bool_var" to "bool_var" +unneeded-not:12:unneeded_not:Consider changing "not someint == 1" to "someint != 1" +unneeded-not:14:unneeded_not:Consider changing "not someint != 1" to "someint == 1" +unneeded-not:16:unneeded_not:Consider changing "not someint < 1" to "someint >= 1" +unneeded-not:18:unneeded_not:Consider changing "not someint > 1" to "someint <= 1" +unneeded-not:20:unneeded_not:Consider changing "not someint <= 1" to "someint > 1" +unneeded-not:22:unneeded_not:Consider changing "not someint >= 1" to "someint < 1" +unneeded-not:24:unneeded_not:Consider changing "not not someint" to "someint" +unneeded-not:26:unneeded_not:Consider changing "not bool_var == True" to "bool_var != True" +unneeded-not:28:unneeded_not:Consider changing "not bool_var == False" to "bool_var != False" +unneeded-not:30:unneeded_not:Consider changing "not bool_var != True" to "bool_var == True" +unneeded-not:32:unneeded_not:Consider changing "not True == True" to "True != True" |